⚡ Bolt: canonicalize documentation links and fix broken security URLs#31
⚡ Bolt: canonicalize documentation links and fix broken security URLs#31soktri3 wants to merge 1 commit into
Conversation
- Updated `spec.modelcontextprotocol.io` to stable canonical URL - Canonicalized repository links to avoid redirects after renames - Added trailing slashes to Contributor Covenant links to eliminate 301s - Fixed broken HackerOne submission links in SECURITY.md - Updated Mozilla diversity link to its new canonical location - Ensured consistency between root and profile/ documents Co-authored-by: soktri3 <170663878+soktri3@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates various documentation links across the repository, including security reporting URLs, specification references, and community resources. Key changes include migrating links from the specification repository to the main modelcontextprotocol repository and updating HackerOne reporting paths. A review comment points out an inconsistency in profile/README.md where a discussion link was updated to a repository-level URL while other parts of the documentation still point to the organization-level discussions, suggesting a revert to maintain consistency.
| We welcome contributions of all kinds! Whether you want to fix bugs, improve documentation, or propose new features, please see our [contributing guide](CONTRIBUTING.md) to get started. | ||
|
|
||
| Have questions? Join the discussion in our [community forum](https://github.com/orgs/modelcontextprotocol/discussions). | ||
| Have questions? Join the discussion in our [community forum](https://github.com/modelcontextprotocol/modelcontextprotocol/discussions). |
There was a problem hiding this comment.
This change introduces an inconsistency within the file and across the project's documentation. Line 18 of this same file still points to the organization-level discussions (https://github.com/orgs/modelcontextprotocol/discussions), as does line 10 of the root CONTRIBUTING.md for general discussions. Updating this link to the repository-level discussions while leaving the others pointing to the organization level creates confusion about the canonical 'community forum'. It is recommended to keep this link pointing to the organization-level discussions to maintain consistency.
| Have questions? Join the discussion in our [community forum](https://github.com/modelcontextprotocol/modelcontextprotocol/discussions). | |
| Have questions? Join the discussion in our [community forum](https://github.com/orgs/modelcontextprotocol/discussions). |
Review Summary by QodoCanonicalize documentation links and fix broken security URLs
WalkthroughsDescription• Canonicalize specification URL from subdomain to main domain • Fix broken HackerOne security submission links • Add trailing slashes to Contributor Covenant documentation URLs • Update Mozilla diversity repository to inclusion repository • Redirect specification discussions to correct repository Diagramflowchart LR
A["Non-canonical URLs"] -->|"Remove redirects"| B["Canonical URLs"]
C["Broken security links"] -->|"Fix endpoints"| D["Valid HackerOne URLs"]
E["Missing trailing slashes"] -->|"Add slashes"| F["Proper URL format"]
G["Outdated repo references"] -->|"Update names"| H["Current repo names"]
File Changes1. CODE_OF_CONDUCT.md
|
Code Review by Qodo
1. Conflicting discussion links
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fb1839f52b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| We welcome contributions of all kinds! Whether you want to fix bugs, improve documentation, or propose new features, please see our [contributing guide](CONTRIBUTING.md) to get started. | ||
|
|
||
| Have questions? Join the discussion in our [community forum](https://github.com/orgs/modelcontextprotocol/discussions). | ||
| Have questions? Join the discussion in our [community forum](https://github.com/modelcontextprotocol/modelcontextprotocol/discussions). |
There was a problem hiding this comment.
This change routes the “community forum” to modelcontextprotocol/modelcontextprotocol/discussions, which is the spec-repo discussion board, not the org-wide forum used elsewhere for general questions. In this repo, CONTRIBUTING.md explicitly separates spec-specific discussions from general organization discussions, and the same README header still links to orgs/modelcontextprotocol/discussions; keeping this link repo-scoped can misdirect non-spec questions and fragment discussion traffic.
Useful? React with 👍 / 👎.
1 participant
💡 What: Updated documentation and community links across the organization profile to use their final canonical destination URLs. This includes fixing broken repository references and adding trailing slashes to external documentation links.
🎯 Why: Using non-canonical URLs (e.g., those missing trailing slashes or using old repository names) triggers server-side HTTP redirects (301, 302, 307, or 308). Each redirect adds at least one extra network round-trip (RTT), which can significantly delay page load or documentation navigation for users, especially on higher-latency connections.
📊 Impact:
spec.modelcontextprotocol.iowith the stable canonical specification URL.🔬 Measurement: Verified using
curl -s -o /dev/null -w "%{http_code} -> %{url_effective}\n" [URL]. All updated links now return200 OKdirectly or lead to the final versioned destination without redundant intermediate redirects.PR created automatically by Jules for task 14276889818735526820 started by @soktri3