From 0700bd9b3d6da8026a464ac02f4763068675daf5 Mon Sep 17 00:00:00 2001 From: Cinthia Davalos Date: Thu, 7 May 2026 16:29:02 -0600 Subject: [PATCH 1/2] Replaced wrapped of Angular materials in Bazel. Replacing tf_external_sass_library, tf_sass_library and tf_sass_lbinary with direct calls to sass_binary, sass_library, and npm_sass_library from @io_bazel_rules_sass. --- WORKSPACE | 10 ++--- tensorboard/defs/defs.bzl | 39 ------------------- .../debugger_v2/tf_debugger_v2_plugin/BUILD | 6 ++- .../tf_debugger_v2_plugin/views/common/BUILD | 4 +- .../views/execution_data/BUILD | 6 ++- .../tf_debugger_v2_plugin/views/graph/BUILD | 9 +++-- .../views/graph_executions/BUILD | 6 ++- .../views/source_files/BUILD | 6 ++- .../views/stack_trace/BUILD | 6 ++- tensorboard/webapp/BUILD | 11 ++++-- tensorboard/webapp/alert/views/BUILD | 6 ++- tensorboard/webapp/core/views/BUILD | 6 ++- tensorboard/webapp/feature_flag/views/BUILD | 6 ++- tensorboard/webapp/header/BUILD | 9 +++-- tensorboard/webapp/metrics/views/BUILD | 8 ++-- .../webapp/metrics/views/card_renderer/BUILD | 33 ++++++++++------ .../webapp/metrics/views/main_view/BUILD | 24 ++++++++---- .../webapp/metrics/views/right_pane/BUILD | 9 +++-- .../views/right_pane/saving_pins_dialog/BUILD | 6 ++- .../right_pane/scalar_column_editor/BUILD | 6 ++- .../webapp/notification_center/_views/BUILD | 6 ++- tensorboard/webapp/plugins/BUILD | 6 ++- .../webapp/runs/views/runs_table/BUILD | 15 ++++--- tensorboard/webapp/theme/BUILD | 4 +- tensorboard/webapp/widgets/card_fob/BUILD | 9 +++-- .../widgets/content_wrapping_input/BUILD | 6 ++- tensorboard/webapp/widgets/data_table/BUILD | 24 ++++++++---- tensorboard/webapp/widgets/dropdown/BUILD | 6 ++- .../webapp/widgets/experiment_alias/BUILD | 6 ++- tensorboard/webapp/widgets/filter_input/BUILD | 6 ++- tensorboard/webapp/widgets/histogram/BUILD | 6 ++- .../webapp/widgets/line_chart_v2/BUILD | 6 ++- .../widgets/line_chart_v2/sub_view/BUILD | 9 +++-- tensorboard/webapp/widgets/range_input/BUILD | 6 ++- tensorboard/webapp/widgets/text/BUILD | 6 ++- 35 files changed, 195 insertions(+), 142 deletions(-) diff --git a/WORKSPACE b/WORKSPACE index 2d3bbf9fc54..92ac2d0b52b 100644 --- a/WORKSPACE +++ b/WORKSPACE @@ -120,15 +120,15 @@ esbuild_repositories(npm_repository = "npm") # rules_sass release information is difficult to find but it does seem to # regularly release with same cadence and version as core sass. # We typically upgrade this library whenever we upgrade rules_nodejs. +# The version used here is the most recent release as of 2023-07-11, which is the same version used by rules_nodejs 5.8.1. # -# rules_sass 1.55.0: https://github.com/bazelbuild/rules_sass/tree/1.55.0 +# rules_sass: https://github.com/bazelbuild/rules_sass/tags http_archive( name = "io_bazel_rules_sass", - sha256 = "1ea0103fa6adcb7d43ff26373b5082efe1d4b2e09c4f34f8a8f8b351e9a8a9b0", - strip_prefix = "rules_sass-1.55.0", + sha256 = "4285781b24dfd07cb01fcc2324faec87818d0f2174b02e0ed9038f6f809de80a", + strip_prefix = "rules_sass-1.69.5", urls = [ - "http://mirror.tensorflow.org/github.com/bazelbuild/rules_sass/archive/1.55.0.zip", - "https://github.com/bazelbuild/rules_sass/archive/1.55.0.zip", + "https://github.com/bazelbuild/rules_sass/archive/refs/tags/1.69.5.tar.gz", ], ) diff --git a/tensorboard/defs/defs.bzl b/tensorboard/defs/defs.bzl index 9589824f9d4..f07d031babe 100644 --- a/tensorboard/defs/defs.bzl +++ b/tensorboard/defs/defs.bzl @@ -249,45 +249,6 @@ def tf_svg_bundle(name, srcs, out): ], ) -def tf_sass_binary(deps = [], include_paths = [], strict_deps = True, **kwargs): - """TensorBoard wrap for declaring SASS binary. - - It adds dependency on theme by default then add include Angular material - theme library paths for better node_modules library resolution. - - strict_deps is included here and intentionally ignored so it can be used - internally. - """ - sass_binary( - deps = deps, - include_paths = include_paths + [ - "external/npm/node_modules", - ], - sourcemap = False, - **kwargs - ) - -def tf_sass_library(**kwargs): - """TensorBoard wrap for declaring SASS library. - - It re-exports the sass_libray symbol so users do not have to depend on - "@io_bazel_rules_sass//:defs.bzl". - """ - sass_library( - **kwargs - ) - -def tf_external_sass_libray(**kwargs): - """TensorBoard wrapper for declaring external SASS dependency. - - When an external (NPM) package have SASS files that has `import` statements, - TensorBoard has to depdend on them very specifically. This rule allows SASS - modules in NPM packages to be built properly. - """ - npm_sass_library( - **kwargs - ) - def tf_ng_module(assets = [], **kwargs): """TensorBoard wrapper for Angular modules.""" tf_ts_library( diff --git a/tensorboard/plugins/debugger_v2/tf_debugger_v2_plugin/BUILD b/tensorboard/plugins/debugger_v2/tf_debugger_v2_plugin/BUILD index b849cc35c73..7f21c22cec5 100644 --- a/tensorboard/plugins/debugger_v2/tf_debugger_v2_plugin/BUILD +++ b/tensorboard/plugins/debugger_v2/tf_debugger_v2_plugin/BUILD @@ -1,13 +1,15 @@ -load("//tensorboard/defs:defs.bzl", "tf_ng_module", "tf_ng_web_test_suite", "tf_sass_binary", "tf_ts_library") +load("@io_bazel_rules_sass//:defs.bzl", "sass_binary") load("@rules_python//python:py_binary.bzl", "py_binary") +load("//tensorboard/defs:defs.bzl", "tf_ng_module", "tf_ng_web_test_suite", "tf_ts_library") package(default_visibility = ["//tensorboard:internal"]) licenses(["notice"]) -tf_sass_binary( +sass_binary( name = "debugger_component_style", src = "debugger_component.scss", + include_paths = ["external/npm/node_modules"], deps = ["//tensorboard/webapp/theme"], ) diff --git a/tensorboard/plugins/debugger_v2/tf_debugger_v2_plugin/views/common/BUILD b/tensorboard/plugins/debugger_v2/tf_debugger_v2_plugin/views/common/BUILD index 9cdf2085484..33a0eba07c7 100644 --- a/tensorboard/plugins/debugger_v2/tf_debugger_v2_plugin/views/common/BUILD +++ b/tensorboard/plugins/debugger_v2/tf_debugger_v2_plugin/views/common/BUILD @@ -1,10 +1,10 @@ -load("//tensorboard/defs:defs.bzl", "tf_sass_library") +load("@io_bazel_rules_sass//:defs.bzl", "sass_library") package(default_visibility = ["//tensorboard:internal"]) licenses(["notice"]) -tf_sass_library( +sass_library( name = "style_lib", srcs = ["_lib.scss"], deps = ["//tensorboard/webapp:angular_material_sass_deps"], diff --git a/tensorboard/plugins/debugger_v2/tf_debugger_v2_plugin/views/execution_data/BUILD b/tensorboard/plugins/debugger_v2/tf_debugger_v2_plugin/views/execution_data/BUILD index 1eceb24a18c..779316b4d0c 100644 --- a/tensorboard/plugins/debugger_v2/tf_debugger_v2_plugin/views/execution_data/BUILD +++ b/tensorboard/plugins/debugger_v2/tf_debugger_v2_plugin/views/execution_data/BUILD @@ -1,12 +1,14 @@ -load("//tensorboard/defs:defs.bzl", "tf_ng_module", "tf_sass_binary", "tf_ts_library") +load("@io_bazel_rules_sass//:defs.bzl", "sass_binary") +load("//tensorboard/defs:defs.bzl", "tf_ng_module", "tf_ts_library") package(default_visibility = ["//tensorboard:internal"]) licenses(["notice"]) -tf_sass_binary( +sass_binary( name = "execution_data_styles", src = "execution_data_component.scss", + include_paths = ["external/npm/node_modules"], deps = [ "//tensorboard/webapp:angular_material_sass_deps", "//tensorboard/webapp/theme", diff --git a/tensorboard/plugins/debugger_v2/tf_debugger_v2_plugin/views/graph/BUILD b/tensorboard/plugins/debugger_v2/tf_debugger_v2_plugin/views/graph/BUILD index 5305d0a0334..3428d912cf4 100644 --- a/tensorboard/plugins/debugger_v2/tf_debugger_v2_plugin/views/graph/BUILD +++ b/tensorboard/plugins/debugger_v2/tf_debugger_v2_plugin/views/graph/BUILD @@ -1,21 +1,24 @@ -load("//tensorboard/defs:defs.bzl", "tf_ng_module", "tf_sass_binary", "tf_ts_library") +load("@io_bazel_rules_sass//:defs.bzl", "sass_binary") +load("//tensorboard/defs:defs.bzl", "tf_ng_module", "tf_ts_library") package(default_visibility = ["//tensorboard:internal"]) licenses(["notice"]) -tf_sass_binary( +sass_binary( name = "graph_styles", src = "graph_component.scss", + include_paths = ["external/npm/node_modules"], deps = [ "//tensorboard/plugins/debugger_v2/tf_debugger_v2_plugin/views/common:style_lib", "//tensorboard/webapp/theme", ], ) -tf_sass_binary( +sass_binary( name = "graph_op_styles", src = "graph_op_component.scss", + include_paths = ["external/npm/node_modules"], deps = [ "//tensorboard/plugins/debugger_v2/tf_debugger_v2_plugin/views/common:style_lib", "//tensorboard/webapp:angular_material_sass_deps", diff --git a/tensorboard/plugins/debugger_v2/tf_debugger_v2_plugin/views/graph_executions/BUILD b/tensorboard/plugins/debugger_v2/tf_debugger_v2_plugin/views/graph_executions/BUILD index f4b85ab1653..47e77627a85 100644 --- a/tensorboard/plugins/debugger_v2/tf_debugger_v2_plugin/views/graph_executions/BUILD +++ b/tensorboard/plugins/debugger_v2/tf_debugger_v2_plugin/views/graph_executions/BUILD @@ -1,12 +1,14 @@ -load("//tensorboard/defs:defs.bzl", "tf_ng_module", "tf_sass_binary", "tf_ts_library") +load("@io_bazel_rules_sass//:defs.bzl", "sass_binary") +load("//tensorboard/defs:defs.bzl", "tf_ng_module", "tf_ts_library") package(default_visibility = ["//tensorboard:internal"]) licenses(["notice"]) -tf_sass_binary( +sass_binary( name = "graph_executions_styles", src = "graph_executions_component.scss", + include_paths = ["external/npm/node_modules"], deps = [ "//tensorboard/plugins/debugger_v2/tf_debugger_v2_plugin/views/common:style_lib", "//tensorboard/webapp/theme", diff --git a/tensorboard/plugins/debugger_v2/tf_debugger_v2_plugin/views/source_files/BUILD b/tensorboard/plugins/debugger_v2/tf_debugger_v2_plugin/views/source_files/BUILD index 8c0ce03dd94..521eaf1028f 100644 --- a/tensorboard/plugins/debugger_v2/tf_debugger_v2_plugin/views/source_files/BUILD +++ b/tensorboard/plugins/debugger_v2/tf_debugger_v2_plugin/views/source_files/BUILD @@ -1,12 +1,14 @@ -load("//tensorboard/defs:defs.bzl", "tf_ng_module", "tf_sass_binary", "tf_ts_library") +load("@io_bazel_rules_sass//:defs.bzl", "sass_binary") +load("//tensorboard/defs:defs.bzl", "tf_ng_module", "tf_ts_library") package(default_visibility = ["//tensorboard:internal"]) licenses(["notice"]) -tf_sass_binary( +sass_binary( name = "source_files_component_style", src = "source_files_component.scss", + include_paths = ["external/npm/node_modules"], deps = ["//tensorboard/webapp/theme"], ) diff --git a/tensorboard/plugins/debugger_v2/tf_debugger_v2_plugin/views/stack_trace/BUILD b/tensorboard/plugins/debugger_v2/tf_debugger_v2_plugin/views/stack_trace/BUILD index f755476ccfe..4a427994aa0 100644 --- a/tensorboard/plugins/debugger_v2/tf_debugger_v2_plugin/views/stack_trace/BUILD +++ b/tensorboard/plugins/debugger_v2/tf_debugger_v2_plugin/views/stack_trace/BUILD @@ -1,12 +1,14 @@ -load("//tensorboard/defs:defs.bzl", "tf_ng_module", "tf_sass_binary", "tf_ts_library") +load("@io_bazel_rules_sass//:defs.bzl", "sass_binary") +load("//tensorboard/defs:defs.bzl", "tf_ng_module", "tf_ts_library") package(default_visibility = ["//tensorboard:internal"]) licenses(["notice"]) -tf_sass_binary( +sass_binary( name = "stack_trace_styles", src = "stack_trace_component.scss", + include_paths = ["external/npm/node_modules"], deps = [ "//tensorboard/plugins/debugger_v2/tf_debugger_v2_plugin/views/common:style_lib", "//tensorboard/webapp/theme", diff --git a/tensorboard/webapp/BUILD b/tensorboard/webapp/BUILD index e701e6ad829..0d9755c41d1 100644 --- a/tensorboard/webapp/BUILD +++ b/tensorboard/webapp/BUILD @@ -1,4 +1,5 @@ -load("//tensorboard/defs:defs.bzl", "tf_external_sass_libray", "tf_ng_module", "tf_ng_prod_js_binary", "tf_ng_web_test_suite", "tf_sass_binary", "tf_svg_bundle", "tf_ts_library") +load("@io_bazel_rules_sass//:defs.bzl", "npm_sass_library", "sass_binary", "sass_library") +load("//tensorboard/defs:defs.bzl", "tf_ng_module", "tf_ng_prod_js_binary", "tf_ng_web_test_suite", "tf_svg_bundle", "tf_ts_library") load("//tensorboard/defs:js.bzl", "tf_resource_digest_suffixer") load("//tensorboard/defs:web.bzl", "tb_combine_html", "tf_web_library") @@ -86,9 +87,10 @@ tf_ts_library( ], ) -tf_sass_binary( +sass_binary( name = "app_styles", src = "app_container.scss", + include_paths = ["external/npm/node_modules"], deps = ["//tensorboard/webapp/theme"], ) @@ -379,13 +381,14 @@ tf_svg_bundle( out = "icon_bundle.svg", ) -tf_external_sass_libray( +npm_sass_library( name = "angular_material_sass_deps", deps = ["@npm//@angular/material"], ) -tf_sass_binary( +sass_binary( name = "styles", src = "styles.scss", + include_paths = ["external/npm/node_modules"], deps = ["//tensorboard/webapp/theme"], ) diff --git a/tensorboard/webapp/alert/views/BUILD b/tensorboard/webapp/alert/views/BUILD index 8e846f96215..18cc93958ba 100644 --- a/tensorboard/webapp/alert/views/BUILD +++ b/tensorboard/webapp/alert/views/BUILD @@ -1,10 +1,12 @@ -load("//tensorboard/defs:defs.bzl", "tf_ng_module", "tf_sass_binary", "tf_ts_library") +load("@io_bazel_rules_sass//:defs.bzl", "sass_binary") +load("//tensorboard/defs:defs.bzl", "tf_ng_module", "tf_ts_library") package(default_visibility = ["//tensorboard:internal"]) -tf_sass_binary( +sass_binary( name = "alert_display_snackbar_styles", src = "alert_display_snackbar_container.scss", + include_paths = ["external/npm/node_modules"], ) tf_ng_module( diff --git a/tensorboard/webapp/core/views/BUILD b/tensorboard/webapp/core/views/BUILD index 7cd765e171f..52ef18642a3 100644 --- a/tensorboard/webapp/core/views/BUILD +++ b/tensorboard/webapp/core/views/BUILD @@ -1,10 +1,12 @@ -load("//tensorboard/defs:defs.bzl", "tf_ng_module", "tf_sass_binary", "tf_ts_library") +load("@io_bazel_rules_sass//:defs.bzl", "sass_binary") +load("//tensorboard/defs:defs.bzl", "tf_ng_module", "tf_ts_library") package(default_visibility = ["//tensorboard:internal"]) -tf_sass_binary( +sass_binary( name = "layout_styles", src = "layout_container.scss", + include_paths = ["external/npm/node_modules"], deps = ["//tensorboard/webapp/theme"], ) diff --git a/tensorboard/webapp/feature_flag/views/BUILD b/tensorboard/webapp/feature_flag/views/BUILD index 75842f0abaa..3e66fa4b5d2 100644 --- a/tensorboard/webapp/feature_flag/views/BUILD +++ b/tensorboard/webapp/feature_flag/views/BUILD @@ -1,12 +1,14 @@ -load("//tensorboard/defs:defs.bzl", "tf_ng_module", "tf_sass_binary") +load("@io_bazel_rules_sass//:defs.bzl", "sass_binary") +load("//tensorboard/defs:defs.bzl", "tf_ng_module") package(default_visibility = ["//tensorboard:internal"]) licenses(["notice"]) -tf_sass_binary( +sass_binary( name = "style", src = "feature_flag_dialog_component.scss", + include_paths = ["external/npm/node_modules"], deps = [ "//tensorboard/webapp:angular_material_sass_deps", "//tensorboard/webapp/theme", diff --git a/tensorboard/webapp/header/BUILD b/tensorboard/webapp/header/BUILD index c8bcd55b950..fdf57acf285 100644 --- a/tensorboard/webapp/header/BUILD +++ b/tensorboard/webapp/header/BUILD @@ -1,18 +1,21 @@ -load("//tensorboard/defs:defs.bzl", "tf_ng_module", "tf_sass_binary", "tf_ts_library") +load("@io_bazel_rules_sass//:defs.bzl", "sass_binary") +load("//tensorboard/defs:defs.bzl", "tf_ng_module", "tf_ts_library") package(default_visibility = ["//tensorboard:internal"]) licenses(["notice"]) -tf_sass_binary( +sass_binary( name = "plugin_selector_styles", src = "plugin_selector_component.scss", + include_paths = ["external/npm/node_modules"], deps = ["//tensorboard/webapp/theme"], ) -tf_sass_binary( +sass_binary( name = "header_styles", src = "header_component.scss", + include_paths = ["external/npm/node_modules"], deps = ["//tensorboard/webapp/theme"], ) diff --git a/tensorboard/webapp/metrics/views/BUILD b/tensorboard/webapp/metrics/views/BUILD index 5544836ce17..2c751c235c7 100644 --- a/tensorboard/webapp/metrics/views/BUILD +++ b/tensorboard/webapp/metrics/views/BUILD @@ -1,17 +1,19 @@ -load("//tensorboard/defs:defs.bzl", "tf_ng_module", "tf_sass_binary", "tf_sass_library", "tf_ts_library") +load("@io_bazel_rules_sass//:defs.bzl", "sass_binary", "sass_library") +load("//tensorboard/defs:defs.bzl", "tf_ng_module", "tf_ts_library") package(default_visibility = ["//tensorboard:internal"]) -tf_sass_library( +sass_library( name = "metrics_common_styles", srcs = [ "_common.scss", ], ) -tf_sass_binary( +sass_binary( name = "metrics_container_styles", src = "metrics_container.scss", + include_paths = ["external/npm/node_modules"], deps = [ "//tensorboard/webapp:angular_material_sass_deps", "//tensorboard/webapp/theme", diff --git a/tensorboard/webapp/metrics/views/card_renderer/BUILD b/tensorboard/webapp/metrics/views/card_renderer/BUILD index 288f052416f..f8c3871c5d7 100644 --- a/tensorboard/webapp/metrics/views/card_renderer/BUILD +++ b/tensorboard/webapp/metrics/views/card_renderer/BUILD @@ -1,10 +1,12 @@ -load("//tensorboard/defs:defs.bzl", "tf_ng_module", "tf_sass_binary", "tf_ts_library") +load("@io_bazel_rules_sass//:defs.bzl", "sass_binary") +load("//tensorboard/defs:defs.bzl", "tf_ng_module", "tf_ts_library") package(default_visibility = ["//tensorboard:internal"]) -tf_sass_binary( +sass_binary( name = "card_view_styles", src = "card_view_container.scss", + include_paths = ["external/npm/node_modules"], deps = ["//tensorboard/webapp/theme"], ) @@ -39,9 +41,10 @@ tf_ng_module( ], ) -tf_sass_binary( +sass_binary( name = "data_download_dialog_styles", src = "data_download_dialog_component.scss", + include_paths = ["external/npm/node_modules"], deps = ["//tensorboard/webapp/theme"], ) @@ -76,9 +79,10 @@ tf_ng_module( ], ) -tf_sass_binary( +sass_binary( name = "histogram_card_styles", src = "histogram_card_component.scss", + include_paths = ["external/npm/node_modules"], deps = [ "//tensorboard/webapp/metrics/views:metrics_common_styles", "//tensorboard/webapp/theme", @@ -124,9 +128,10 @@ tf_ng_module( ], ) -tf_sass_binary( +sass_binary( name = "image_card_styles", src = "image_card_component.scss", + include_paths = ["external/npm/node_modules"], deps = [ "//tensorboard/webapp:angular_material_sass_deps", "//tensorboard/webapp/metrics/views:metrics_common_styles", @@ -171,9 +176,10 @@ tf_ng_module( ], ) -tf_sass_binary( +sass_binary( name = "run_name_styles", src = "run_name_component.scss", + include_paths = ["external/npm/node_modules"], deps = ["//tensorboard/webapp/theme"], ) @@ -200,9 +206,10 @@ tf_ng_module( ], ) -tf_sass_binary( +sass_binary( name = "vis_linked_time_selection_warning_styles", src = "vis_linked_time_selection_warning_component.scss", + include_paths = ["external/npm/node_modules"], deps = [ "//tensorboard/webapp:angular_material_sass_deps", "//tensorboard/webapp/theme", @@ -251,9 +258,10 @@ tf_ts_library( ], ) -tf_sass_binary( +sass_binary( name = "scalar_card_styles", src = "scalar_card_component.scss", + include_paths = ["external/npm/node_modules"], deps = [ "//tensorboard/webapp:angular_material_sass_deps", "//tensorboard/webapp/metrics/views:metrics_common_styles", @@ -261,14 +269,16 @@ tf_sass_binary( ], ) -tf_sass_binary( +sass_binary( name = "scalar_card_fob_controller_styles", src = "scalar_card_fob_controller.scss", + include_paths = ["external/npm/node_modules"], ) -tf_sass_binary( +sass_binary( name = "scalar_card_data_table_styles", src = "scalar_card_data_table.scss", + include_paths = ["external/npm/node_modules"], ) tf_ng_module( @@ -358,9 +368,10 @@ tf_ng_module( ], ) -tf_sass_binary( +sass_binary( name = "scalar_card_line_chart_styles", src = "scalar_card_line_chart_component.scss", + include_paths = ["external/npm/node_modules"], deps = ["//tensorboard/webapp/theme"], ) diff --git a/tensorboard/webapp/metrics/views/main_view/BUILD b/tensorboard/webapp/metrics/views/main_view/BUILD index d06a7865781..570545d2f3d 100644 --- a/tensorboard/webapp/metrics/views/main_view/BUILD +++ b/tensorboard/webapp/metrics/views/main_view/BUILD @@ -1,10 +1,12 @@ -load("//tensorboard/defs:defs.bzl", "tf_ng_module", "tf_sass_binary", "tf_ts_library") +load("@io_bazel_rules_sass//:defs.bzl", "sass_binary") +load("//tensorboard/defs:defs.bzl", "tf_ng_module", "tf_ts_library") package(default_visibility = ["//tensorboard:internal"]) -tf_sass_binary( +sass_binary( name = "main_view_styles", src = "main_view_component.scss", + include_paths = ["external/npm/node_modules"], deps = [ "//tensorboard/webapp:angular_material_sass_deps", "//tensorboard/webapp/metrics/views:metrics_common_styles", @@ -12,27 +14,30 @@ tf_sass_binary( ], ) -tf_sass_binary( +sass_binary( name = "filter_input_component_styles", src = "filter_input_component.scss", + include_paths = ["external/npm/node_modules"], deps = [ "//tensorboard/webapp:angular_material_sass_deps", "//tensorboard/webapp/theme", ], ) -tf_sass_binary( +sass_binary( name = "filtered_view_component_styles", src = "filtered_view_component.scss", + include_paths = ["external/npm/node_modules"], deps = [ "//tensorboard/webapp/metrics/views:metrics_common_styles", "//tensorboard/webapp/theme", ], ) -tf_sass_binary( +sass_binary( name = "pinned_view_component_styles", src = "pinned_view_component.scss", + include_paths = ["external/npm/node_modules"], deps = [ "//tensorboard/webapp:angular_material_sass_deps", "//tensorboard/webapp/metrics/views:metrics_common_styles", @@ -40,27 +45,30 @@ tf_sass_binary( ], ) -tf_sass_binary( +sass_binary( name = "card_grid_component_styles", src = "card_grid_component.scss", + include_paths = ["external/npm/node_modules"], deps = [ "//tensorboard/webapp/metrics/views:metrics_common_styles", "//tensorboard/webapp/theme", ], ) -tf_sass_binary( +sass_binary( name = "card_groups_component_styles", src = "card_groups_component.scss", + include_paths = ["external/npm/node_modules"], deps = [ "//tensorboard/webapp/metrics/views:metrics_common_styles", "//tensorboard/webapp/theme", ], ) -tf_sass_binary( +sass_binary( name = "card_group_toolbar_component_styles", src = "card_group_toolbar_component.scss", + include_paths = ["external/npm/node_modules"], deps = [ "//tensorboard/webapp/metrics/views:metrics_common_styles", "//tensorboard/webapp/theme", diff --git a/tensorboard/webapp/metrics/views/right_pane/BUILD b/tensorboard/webapp/metrics/views/right_pane/BUILD index 2c6c21901e8..cc5110d585d 100644 --- a/tensorboard/webapp/metrics/views/right_pane/BUILD +++ b/tensorboard/webapp/metrics/views/right_pane/BUILD @@ -1,19 +1,22 @@ -load("//tensorboard/defs:defs.bzl", "tf_ng_module", "tf_sass_binary", "tf_ts_library") +load("@io_bazel_rules_sass//:defs.bzl", "sass_binary") +load("//tensorboard/defs:defs.bzl", "tf_ng_module", "tf_ts_library") package(default_visibility = ["//tensorboard:internal"]) -tf_sass_binary( +sass_binary( name = "settings_view_styles", src = "settings_view_component.scss", + include_paths = ["external/npm/node_modules"], deps = [ "//tensorboard/webapp:angular_material_sass_deps", "//tensorboard/webapp/theme", ], ) -tf_sass_binary( +sass_binary( name = "saving_pins_checkbox_styles", src = "saving_pins_checkbox_component.scss", + include_paths = ["external/npm/node_modules"], deps = [ "//tensorboard/webapp:angular_material_sass_deps", "//tensorboard/webapp/theme", diff --git a/tensorboard/webapp/metrics/views/right_pane/saving_pins_dialog/BUILD b/tensorboard/webapp/metrics/views/right_pane/saving_pins_dialog/BUILD index 540bcff6a82..b2aa6e283a4 100644 --- a/tensorboard/webapp/metrics/views/right_pane/saving_pins_dialog/BUILD +++ b/tensorboard/webapp/metrics/views/right_pane/saving_pins_dialog/BUILD @@ -1,10 +1,12 @@ -load("//tensorboard/defs:defs.bzl", "tf_ng_module", "tf_sass_binary", "tf_ts_library") +load("@io_bazel_rules_sass//:defs.bzl", "sass_binary") +load("//tensorboard/defs:defs.bzl", "tf_ng_module", "tf_ts_library") package(default_visibility = ["//tensorboard:internal"]) -tf_sass_binary( +sass_binary( name = "saving_pins_dialog_component_styles", src = "saving_pins_dialog_component.scss", + include_paths = ["external/npm/node_modules"], ) tf_ng_module( diff --git a/tensorboard/webapp/metrics/views/right_pane/scalar_column_editor/BUILD b/tensorboard/webapp/metrics/views/right_pane/scalar_column_editor/BUILD index 66b5b13e31a..07835c40582 100644 --- a/tensorboard/webapp/metrics/views/right_pane/scalar_column_editor/BUILD +++ b/tensorboard/webapp/metrics/views/right_pane/scalar_column_editor/BUILD @@ -1,10 +1,12 @@ -load("//tensorboard/defs:defs.bzl", "tf_ng_module", "tf_sass_binary", "tf_ts_library") +load("@io_bazel_rules_sass//:defs.bzl", "sass_binary") +load("//tensorboard/defs:defs.bzl", "tf_ng_module", "tf_ts_library") package(default_visibility = ["//tensorboard:internal"]) -tf_sass_binary( +sass_binary( name = "scalar_column_editor_styles", src = "scalar_column_editor_component.scss", + include_paths = ["external/npm/node_modules"], deps = [ "//tensorboard/webapp:angular_material_sass_deps", "//tensorboard/webapp/theme", diff --git a/tensorboard/webapp/notification_center/_views/BUILD b/tensorboard/webapp/notification_center/_views/BUILD index da3a90082e6..17fb0e3a3dc 100644 --- a/tensorboard/webapp/notification_center/_views/BUILD +++ b/tensorboard/webapp/notification_center/_views/BUILD @@ -1,12 +1,14 @@ -load("//tensorboard/defs:defs.bzl", "tf_ng_module", "tf_sass_binary", "tf_ts_library") +load("@io_bazel_rules_sass//:defs.bzl", "sass_binary") +load("//tensorboard/defs:defs.bzl", "tf_ng_module", "tf_ts_library") package(default_visibility = ["//tensorboard/webapp/notification_center:__subpackages__"]) licenses(["notice"]) -tf_sass_binary( +sass_binary( name = "notification_center_styles", src = "notification_center_component.scss", + include_paths = ["external/npm/node_modules"], deps = [ "//tensorboard/webapp:angular_material_sass_deps", "//tensorboard/webapp/theme", diff --git a/tensorboard/webapp/plugins/BUILD b/tensorboard/webapp/plugins/BUILD index ef34c03baf8..00e30c96825 100644 --- a/tensorboard/webapp/plugins/BUILD +++ b/tensorboard/webapp/plugins/BUILD @@ -1,12 +1,14 @@ -load("//tensorboard/defs:defs.bzl", "tf_ng_module", "tf_sass_binary", "tf_ts_library") +load("@io_bazel_rules_sass//:defs.bzl", "sass_binary") +load("//tensorboard/defs:defs.bzl", "tf_ng_module", "tf_ts_library") package(default_visibility = ["//tensorboard:internal"]) licenses(["notice"]) -tf_sass_binary( +sass_binary( name = "plugins_component_styles", src = "plugins_component.scss", + include_paths = ["external/npm/node_modules"], deps = ["//tensorboard/webapp/theme"], ) diff --git a/tensorboard/webapp/runs/views/runs_table/BUILD b/tensorboard/webapp/runs/views/runs_table/BUILD index 75f47fe218f..ffe5518937f 100644 --- a/tensorboard/webapp/runs/views/runs_table/BUILD +++ b/tensorboard/webapp/runs/views/runs_table/BUILD @@ -1,33 +1,38 @@ -load("//tensorboard/defs:defs.bzl", "tf_ng_module", "tf_sass_binary", "tf_ts_library") +load("@io_bazel_rules_sass//:defs.bzl", "sass_binary") +load("//tensorboard/defs:defs.bzl", "tf_ng_module", "tf_ts_library") package(default_visibility = ["//tensorboard:internal"]) licenses(["notice"]) -tf_sass_binary( +sass_binary( name = "runs_group_menu_button_styles", src = "runs_group_menu_button_component.scss", + include_paths = ["external/npm/node_modules"], deps = [ "//tensorboard/webapp:angular_material_sass_deps", "//tensorboard/webapp/theme", ], ) -tf_sass_binary( +sass_binary( name = "regex_edit_dialog_styles", src = "regex_edit_dialog_component.scss", + include_paths = ["external/npm/node_modules"], deps = ["//tensorboard/webapp/theme"], ) -tf_sass_binary( +sass_binary( name = "filterbar_styles", src = "filterbar_component.scss", + include_paths = ["external/npm/node_modules"], deps = ["//tensorboard/webapp/theme"], ) -tf_sass_binary( +sass_binary( name = "runs_data_table_styles", src = "runs_data_table.scss", + include_paths = ["external/npm/node_modules"], deps = [ "//tensorboard/webapp:angular_material_sass_deps", "//tensorboard/webapp/theme", diff --git a/tensorboard/webapp/theme/BUILD b/tensorboard/webapp/theme/BUILD index 6afa1682489..ba6b72fa173 100644 --- a/tensorboard/webapp/theme/BUILD +++ b/tensorboard/webapp/theme/BUILD @@ -1,10 +1,10 @@ -load("//tensorboard/defs:defs.bzl", "tf_sass_library") +load("@io_bazel_rules_sass//:defs.bzl", "sass_library") package(default_visibility = ["//tensorboard:internal"]) licenses(["notice"]) -tf_sass_library( +sass_library( name = "theme", srcs = [ "_tb_palette.scss", diff --git a/tensorboard/webapp/widgets/card_fob/BUILD b/tensorboard/webapp/widgets/card_fob/BUILD index b4a848ff6af..583c4a42cb9 100644 --- a/tensorboard/webapp/widgets/card_fob/BUILD +++ b/tensorboard/webapp/widgets/card_fob/BUILD @@ -1,19 +1,22 @@ -load("//tensorboard/defs:defs.bzl", "tf_ng_module", "tf_sass_binary", "tf_ts_library") +load("@io_bazel_rules_sass//:defs.bzl", "sass_binary") +load("//tensorboard/defs:defs.bzl", "tf_ng_module", "tf_ts_library") package(default_visibility = ["//tensorboard:internal"]) -tf_sass_binary( +sass_binary( name = "card_fob_styles", src = "card_fob_component.scss", + include_paths = ["external/npm/node_modules"], deps = [ "//tensorboard/webapp:angular_material_sass_deps", "//tensorboard/webapp/theme", ], ) -tf_sass_binary( +sass_binary( name = "card_fob_controller_styles", src = "card_fob_controller_component.scss", + include_paths = ["external/npm/node_modules"], ) tf_ng_module( diff --git a/tensorboard/webapp/widgets/content_wrapping_input/BUILD b/tensorboard/webapp/widgets/content_wrapping_input/BUILD index a5dc7640267..d6a4072440b 100644 --- a/tensorboard/webapp/widgets/content_wrapping_input/BUILD +++ b/tensorboard/webapp/widgets/content_wrapping_input/BUILD @@ -1,10 +1,12 @@ -load("//tensorboard/defs:defs.bzl", "tf_ng_module", "tf_sass_binary", "tf_ts_library") +load("@io_bazel_rules_sass//:defs.bzl", "sass_binary") +load("//tensorboard/defs:defs.bzl", "tf_ng_module", "tf_ts_library") package(default_visibility = ["//tensorboard:internal"]) -tf_sass_binary( +sass_binary( name = "content_wrapping_input_component_styles", src = "content_wrapping_input_component.scss", + include_paths = ["external/npm/node_modules"], deps = [ "//tensorboard/webapp:angular_material_sass_deps", "//tensorboard/webapp/theme", diff --git a/tensorboard/webapp/widgets/data_table/BUILD b/tensorboard/webapp/widgets/data_table/BUILD index be4d4863d2a..c2a43a0b4e2 100644 --- a/tensorboard/webapp/widgets/data_table/BUILD +++ b/tensorboard/webapp/widgets/data_table/BUILD @@ -1,56 +1,64 @@ -load("//tensorboard/defs:defs.bzl", "tf_ng_module", "tf_sass_binary", "tf_ts_library") +load("@io_bazel_rules_sass//:defs.bzl", "sass_binary") +load("//tensorboard/defs:defs.bzl", "tf_ng_module", "tf_ts_library") package(default_visibility = ["//tensorboard:internal"]) -tf_sass_binary( +sass_binary( name = "data_table_styles", src = "data_table_component.scss", + include_paths = ["external/npm/node_modules"], deps = [ "//tensorboard/webapp:angular_material_sass_deps", "//tensorboard/webapp/theme", ], ) -tf_sass_binary( +sass_binary( name = "header_cell_styles", src = "header_cell_component.scss", + include_paths = ["external/npm/node_modules"], deps = [ "//tensorboard/webapp:angular_material_sass_deps", "//tensorboard/webapp/theme", ], ) -tf_sass_binary( +sass_binary( name = "content_cell_styles", src = "content_cell_component.scss", + include_paths = ["external/npm/node_modules"], ) -tf_sass_binary( +sass_binary( name = "data_table_header_styles", src = "data_table_header_component.scss", + include_paths = ["external/npm/node_modules"], ) -tf_sass_binary( +sass_binary( name = "column_selector_component_styles", src = "column_selector_component.scss", + include_paths = ["external/npm/node_modules"], deps = [ "//tensorboard/webapp:angular_material_sass_deps", "//tensorboard/webapp/theme", ], ) -tf_sass_binary( +sass_binary( name = "context_menu_component_styles", src = "context_menu_component.scss", + include_paths = ["external/npm/node_modules"], deps = [ "//tensorboard/webapp:angular_material_sass_deps", "//tensorboard/webapp/theme", ], ) -tf_sass_binary( +sass_binary( name = "filter_dialog_styles", src = "filter_dialog_component.scss", + include_paths = ["external/npm/node_modules"], deps = [ "//tensorboard/webapp:angular_material_sass_deps", "//tensorboard/webapp/theme", diff --git a/tensorboard/webapp/widgets/dropdown/BUILD b/tensorboard/webapp/widgets/dropdown/BUILD index ff69ccddd41..75358455ea3 100644 --- a/tensorboard/webapp/widgets/dropdown/BUILD +++ b/tensorboard/webapp/widgets/dropdown/BUILD @@ -1,12 +1,14 @@ -load("//tensorboard/defs:defs.bzl", "tf_ng_module", "tf_sass_binary", "tf_ts_library") +load("@io_bazel_rules_sass//:defs.bzl", "sass_binary") +load("//tensorboard/defs:defs.bzl", "tf_ng_module", "tf_ts_library") package(default_visibility = ["//tensorboard:internal"]) licenses(["notice"]) -tf_sass_binary( +sass_binary( name = "dropdown_styles", src = "dropdown_component.scss", + include_paths = ["external/npm/node_modules"], deps = [ "//tensorboard/webapp:angular_material_sass_deps", "//tensorboard/webapp/theme", diff --git a/tensorboard/webapp/widgets/experiment_alias/BUILD b/tensorboard/webapp/widgets/experiment_alias/BUILD index 237638759d6..e413310f73f 100644 --- a/tensorboard/webapp/widgets/experiment_alias/BUILD +++ b/tensorboard/webapp/widgets/experiment_alias/BUILD @@ -1,12 +1,14 @@ -load("//tensorboard/defs:defs.bzl", "tf_ng_module", "tf_sass_binary", "tf_ts_library") +load("@io_bazel_rules_sass//:defs.bzl", "sass_binary") +load("//tensorboard/defs:defs.bzl", "tf_ng_module", "tf_ts_library") package(default_visibility = ["//tensorboard:internal"]) licenses(["notice"]) -tf_sass_binary( +sass_binary( name = "experiment_alias_component_styles", src = "experiment_alias_component.scss", + include_paths = ["external/npm/node_modules"], deps = ["//tensorboard/webapp/theme"], ) diff --git a/tensorboard/webapp/widgets/filter_input/BUILD b/tensorboard/webapp/widgets/filter_input/BUILD index 576446e72fa..5f2b7e30502 100644 --- a/tensorboard/webapp/widgets/filter_input/BUILD +++ b/tensorboard/webapp/widgets/filter_input/BUILD @@ -1,12 +1,14 @@ -load("//tensorboard/defs:defs.bzl", "tf_ng_module", "tf_sass_binary", "tf_ts_library") +load("@io_bazel_rules_sass//:defs.bzl", "sass_binary") +load("//tensorboard/defs:defs.bzl", "tf_ng_module", "tf_ts_library") package(default_visibility = ["//tensorboard:internal"]) licenses(["notice"]) -tf_sass_binary( +sass_binary( name = "filter_input_component_styles", src = "filter_input_component.scss", + include_paths = ["external/npm/node_modules"], deps = ["//tensorboard/webapp/theme"], ) diff --git a/tensorboard/webapp/widgets/histogram/BUILD b/tensorboard/webapp/widgets/histogram/BUILD index 9713010e819..801d34c0b0d 100644 --- a/tensorboard/webapp/widgets/histogram/BUILD +++ b/tensorboard/webapp/widgets/histogram/BUILD @@ -1,12 +1,14 @@ -load("//tensorboard/defs:defs.bzl", "tf_ng_module", "tf_sass_binary", "tf_ts_library") +load("@io_bazel_rules_sass//:defs.bzl", "sass_binary") +load("//tensorboard/defs:defs.bzl", "tf_ng_module", "tf_ts_library") package(default_visibility = ["//tensorboard:internal"]) licenses(["notice"]) -tf_sass_binary( +sass_binary( name = "histogram_styles", src = "histogram_component.scss", + include_paths = ["external/npm/node_modules"], deps = ["//tensorboard/webapp/theme"], ) diff --git a/tensorboard/webapp/widgets/line_chart_v2/BUILD b/tensorboard/webapp/widgets/line_chart_v2/BUILD index 8bca910ce58..6e188812942 100644 --- a/tensorboard/webapp/widgets/line_chart_v2/BUILD +++ b/tensorboard/webapp/widgets/line_chart_v2/BUILD @@ -1,12 +1,14 @@ -load("//tensorboard/defs:defs.bzl", "tf_ng_module", "tf_sass_binary", "tf_ts_library") +load("@io_bazel_rules_sass//:defs.bzl", "sass_binary") +load("//tensorboard/defs:defs.bzl", "tf_ng_module", "tf_ts_library") package(default_visibility = ["//tensorboard:internal"]) licenses(["notice"]) -tf_sass_binary( +sass_binary( name = "line_chart_styles", src = "line_chart_component.scss", + include_paths = ["external/npm/node_modules"], deps = ["//tensorboard/webapp/theme"], ) diff --git a/tensorboard/webapp/widgets/line_chart_v2/sub_view/BUILD b/tensorboard/webapp/widgets/line_chart_v2/sub_view/BUILD index 9708dabc726..e66572c8a79 100644 --- a/tensorboard/webapp/widgets/line_chart_v2/sub_view/BUILD +++ b/tensorboard/webapp/widgets/line_chart_v2/sub_view/BUILD @@ -1,19 +1,22 @@ -load("//tensorboard/defs:defs.bzl", "tf_ng_module", "tf_sass_binary", "tf_ts_library") +load("@io_bazel_rules_sass//:defs.bzl", "sass_binary") +load("//tensorboard/defs:defs.bzl", "tf_ng_module", "tf_ts_library") package(default_visibility = ["//tensorboard:internal"]) -tf_sass_binary( +sass_binary( name = "line_chart_axis_view_styles", src = "line_chart_axis_view.scss", + include_paths = ["external/npm/node_modules"], deps = [ "//tensorboard/webapp:angular_material_sass_deps", "//tensorboard/webapp/theme", ], ) -tf_sass_binary( +sass_binary( name = "line_chart_interactive_view_styles", src = "line_chart_interactive_view.scss", + include_paths = ["external/npm/node_modules"], ) tf_ng_module( diff --git a/tensorboard/webapp/widgets/range_input/BUILD b/tensorboard/webapp/widgets/range_input/BUILD index f83b2181fdd..b9839c8f29b 100644 --- a/tensorboard/webapp/widgets/range_input/BUILD +++ b/tensorboard/webapp/widgets/range_input/BUILD @@ -1,10 +1,12 @@ -load("//tensorboard/defs:defs.bzl", "tf_ng_module", "tf_sass_binary", "tf_ts_library") +load("@io_bazel_rules_sass//:defs.bzl", "sass_binary") +load("//tensorboard/defs:defs.bzl", "tf_ng_module", "tf_ts_library") package(default_visibility = ["//tensorboard:internal"]) -tf_sass_binary( +sass_binary( name = "range_input_styles", src = "range_input_component.scss", + include_paths = ["external/npm/node_modules"], deps = [ "//tensorboard/webapp:angular_material_sass_deps", "//tensorboard/webapp/theme", diff --git a/tensorboard/webapp/widgets/text/BUILD b/tensorboard/webapp/widgets/text/BUILD index 88ff418b083..e6638dc7c8d 100644 --- a/tensorboard/webapp/widgets/text/BUILD +++ b/tensorboard/webapp/widgets/text/BUILD @@ -1,12 +1,14 @@ -load("//tensorboard/defs:defs.bzl", "tf_ng_module", "tf_sass_binary") +load("@io_bazel_rules_sass//:defs.bzl", "sass_binary") +load("//tensorboard/defs:defs.bzl", "tf_ng_module") package(default_visibility = ["//tensorboard:internal"]) licenses(["notice"]) -tf_sass_binary( +sass_binary( name = "truncated_path_styles", src = "truncated_path_component.scss", + include_paths = ["external/npm/node_modules"], ) tf_ng_module( From cc3aafbd6c48db4116673323f732ba4145f9eab9 Mon Sep 17 00:00:00 2001 From: Cinthia Davalos Date: Thu, 7 May 2026 16:33:49 -0600 Subject: [PATCH 2/2] Removed unused dependency --- tensorboard/webapp/BUILD | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tensorboard/webapp/BUILD b/tensorboard/webapp/BUILD index 0d9755c41d1..706289be449 100644 --- a/tensorboard/webapp/BUILD +++ b/tensorboard/webapp/BUILD @@ -1,4 +1,4 @@ -load("@io_bazel_rules_sass//:defs.bzl", "npm_sass_library", "sass_binary", "sass_library") +load("@io_bazel_rules_sass//:defs.bzl", "npm_sass_library", "sass_binary") load("//tensorboard/defs:defs.bzl", "tf_ng_module", "tf_ng_prod_js_binary", "tf_ng_web_test_suite", "tf_svg_bundle", "tf_ts_library") load("//tensorboard/defs:js.bzl", "tf_resource_digest_suffixer") load("//tensorboard/defs:web.bzl", "tb_combine_html", "tf_web_library")