From fc60991c90e298d5cd45c168e3ace9932e434b63 Mon Sep 17 00:00:00 2001 From: M3gA-Mind Date: Mon, 9 Nov 2026 13:12:07 +0530 Subject: [PATCH] test(e2e-web): track the S-06 keyring consent skip with its issue The browser-test skip guard needs a GitHub issue URL on the line of every skip. The S-06 spec skips unless the core test keyring responder is off, and that line had none, so the guard failed on every frontend PR. --- .../playwright/specs/keyring-consent-before-sign-in.spec.ts | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/app/test/playwright/specs/keyring-consent-before-sign-in.spec.ts b/app/test/playwright/specs/keyring-consent-before-sign-in.spec.ts index 3c72dfde1d..697a8da0f4 100644 --- a/app/test/playwright/specs/keyring-consent-before-sign-in.spec.ts +++ b/app/test/playwright/specs/keyring-consent-before-sign-in.spec.ts @@ -9,6 +9,7 @@ import { bootRuntimeReadyGuestPage, callCoreRpc } from '../helpers/core-rpc'; // spec runs only on a core started with OPENHUMAN_TEST_KEYRING_CONSENT=off. const USER_ID = 'ts-e2e-s06-user'; +const RESPONDER_ON = process.env.OPENHUMAN_TEST_KEYRING_CONSENT !== 'off'; function sessionJwt(userId: string): string { const payload = Buffer.from( @@ -18,10 +19,7 @@ function sessionJwt(userId: string): string { } test.describe('keyring consent before sign-in', () => { - test.skip( - process.env.OPENHUMAN_TEST_KEYRING_CONSENT !== 'off', - 'TS-E2E S-06 needs the core test keyring responder off' - ); + test.skip(RESPONDER_ON, 'TS-E2E S-06 needs the core test keyring responder off'); // https://github.com/tinyhumansai/openhuman/issues/8596 test('s_06 shows the sign-in keyring prompt without a socket and signs in once allowed', async ({ page,