-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Open
Description
Official FAQ
- I have checked the official FAQ.
Ventoy Version
1.1.10
What about latest release
Yes. I have tried the latest release, but the bug still exist.
Try alternative boot mode
No. I didn't try these alternative boot modes.
BIOS Mode
Both
Partition Style
MBR
Disk Capacity
N/A
Disk Manufacturer
N/A
Image file checksum (if applicable)
None
Image file download link (if applicable)
No response
What happened?
There appears to be a shell logic bug in IMG/cpio/ventoy/hook/debian/porteus-hook.sh.
In this block:
grep ... | awk ... | while read vtline; do
# ...
vtFindFlag=1
donevtFindFlag is modified inside a pipeline loop (subshell in busybox ash), then checked outside the loop. So vtFindFlag remains 0 outside, and the fallback branch runs even when files were already found/patched.
Expected behavior: vtFindFlag should reflect whether any match was found before deciding to run fallback logic.
Suggested fix ideas (I can create a PR):
- Avoid pipeline subshell for the loop (e.g. iterate over temp file/list)
Relevant file:
IMG/cpio/ventoy/hook/debian/porteus-hook.sh
Thank you!
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels