fix navigation on recent JDTLS: accept both class and java files in jdt uris#68
Open
sideshowcoder wants to merge 1 commit into
Open
Conversation
In a recent version of jdtls the lsp started returing java files directly instead of the class files for the navigation query, to keep the regex compatible this accepts both either .class or .java files, formatting the source file name correctly as PACKAGE/FILENAME.java either way.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In a recent version of JDTLS the jsonrpc is returing
.javafiles directly instead of the.classfiles for the navigation query, only including the.classas part of the query string of the URI, to keep the regex compatible this accepts both either.classor.javafiles, formatting the source file name correctly asPACKAGE/FILENAME.javaeither way.The JSON RPC responses are now including the jdt uri with the Java file, with the class file as part of the query string of the URI, which is not matched by the regex.
This fixes this so both
.javaand.classare accepted for backwards compatibility to older JDTLS versions.