Repository navigation
Stream panel backup archives within production memory capacity - #19
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Production backup verification exposed a memory limit: serializing a 241 MiB database as one base64 JSON string exhausted the 4 GiB panel host and killed the panel. Offloading the work protected the request thread but retained the allocation peak.
Stream the snapshot through base64 JSON serialization, gzip and authenticated encryption. This retains the existing backup format, integrity checks and upload verification while removing simultaneous full database/base64/JSON allocations. Bound background work to two minutes so an interrupted worker cannot leave its promise pending indefinitely.
Validation: typecheck, all 144 isolated test files, backup credential-restore integration tests and archive round-trip compatibility pass. A new 160 MiB snapshot regression requires peak resident memory growth below 128 MiB. Foody production traffic remains under continuous monitoring during this corrective release.
The exact streaming implementation was also exercised against the production 241 MiB snapshot in an isolated process: 59,212,682 encrypted bytes in 6.32 seconds, peak RSS 319,184 KiB. The previous whole-file implementation was killed by the host OOM killer around 1.3 GiB RSS. No credentials or archive contents were logged.