Skip to content

fix(rocksdb): return errors for unsupported subtree depths#2124

Open
Mr-kay-cloud2 wants to merge 1 commit into
0xMiden:nextfrom
Mr-kay-cloud2:fix/rocksdb-helper-errors
Open

fix(rocksdb): return errors for unsupported subtree depths#2124
Mr-kay-cloud2 wants to merge 1 commit into
0xMiden:nextfrom
Mr-kay-cloud2:fix/rocksdb-helper-errors

Conversation

@Mr-kay-cloud2
Copy link
Copy Markdown
Contributor

Summary

  • Makes RocksDB subtree helper paths return StorageError for unsupported subtree depths.
  • Removes panic/expect behavior from subtree key and column-family lookup helpers.
  • Threads the fallible helper results through subtree read/write/delete paths.

Closes #1730

Testing

  • rustfmt +nightly --edition 2024 crates/large-smt-backend-rocksdb/src/rocksdb.rs
  • cargo check -p miden-large-smt-backend-rocksdb --all-targets could not run locally on Windows because the miden-agglayer dependency checkout fails on an invalid : path in a submodule file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RocksDB storage helpers panic on unexpected input instead of returning errors

1 participant