Skip to content

perf(store): avoid duplicate nullifier iteration#2127

Open
Mr-kay-cloud2 wants to merge 1 commit into
0xMiden:nextfrom
Mr-kay-cloud2:fix/nullifier-single-pass
Open

perf(store): avoid duplicate nullifier iteration#2127
Mr-kay-cloud2 wants to merge 1 commit into
0xMiden:nextfrom
Mr-kay-cloud2:fix/nullifier-single-pass

Conversation

@Mr-kay-cloud2
Copy link
Copy Markdown
Contributor

Summary

  • Avoids traversing block-created nullifiers twice in State::compute_tree_mutations.
  • Builds the nullifier mutation input while checking for duplicate nullifiers.
  • Reuses the prepared mutations when computing the nullifier tree update.

Closes #1548

Testing

  • rustfmt +nightly --edition 2024 crates/store/src/state/apply_block.rs
  • cargo check -p miden-node-store --all-targets could not run locally on Windows because the miden-agglayer dependency checkout fails on an invalid : path in a submodule file.

@Mr-kay-cloud2 Mr-kay-cloud2 force-pushed the fix/nullifier-single-pass branch from 7ec0898 to 95353a3 Compare May 24, 2026 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

perf: avoid iterating over nullifiers twice

1 participant