fix(rpc): move submit proof checks off async runtime#2133
Open
Ollie202 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially addresses #1976.
Problem
The RPC transaction submission endpoints perform CPU-heavy proof work directly inside async request handlers:
SubmitProvenTxverifies the submitted transaction proof withTransactionVerifier::verify.SubmitProvenTxBatchlocally re-proves the proposed batch to compare it with the submitted batch proof.Both operations can block Tokio worker threads while the RPC service is handling requests.
Changes
SubmitProvenTxtransaction proof verification intospawn_blocking_in_current_span.SubmitProvenTxBatchlocal batch proof comparison intospawn_blocking_in_current_span.Testing
cargo +nightly fmt --check --allgit diff --checkI also tried
cargo check -p miden-node-rpcandcargo check --manifest-path crates/rpc/Cargo.toml, but both stop during dependency checkout on Windows because the current protocol dependency pulls an AggLayer submodule file with:in the filename:tools/addRollupType/addRollupMainnet10/add_rollup_type_10_output-2025-03-11T15:54:21.263Z.json