feat: gate RPC network tx submission behind internal auth header#2141
Merged
Conversation
kkovaacs
force-pushed
the
krisztian/allow-network-transactions
branch
from
58f2f59 to
1257284
Compare
Mirko-von-Leipzig
approved these changes
May 26, 2026
Collaborator
Mirko-von-Leipzig
left a comment
Mirko-von-Leipzig
left a comment
There was a problem hiding this comment.
LGTM modulo removing the header name config
bobbinth
reviewed
May 26, 2026
Comment on lines
+21
to
+28
| /// Optional metadata header value for internal network-transaction RPC authentication. | ||
| #[arg( | ||
| long = "rpc.network-tx-auth-header-value", | ||
| env = "MIDEN_NODE_RPC_NETWORK_TX_AUTH_HEADER_VALUE", | ||
| value_name = "VALUE", | ||
| help_heading = super::section::RPC_CONFIGURATION_HELP_HEADING | ||
| )] | ||
| pub network_tx_auth_header_value: Option<String>, |
Contributor
There was a problem hiding this comment.
The idea is that this would be a secret value that internal RPC nodes would be initialized with, but external RPC nodes wouldn't know - right?
Collaborator
There was a problem hiding this comment.
Or in the simplest case, only the sequencer so long as one ensures that the ntx builder is connected to it and not a random internal full node
Adds optional internal auth-header support to the shared gRPC client builder, enforces that header in RPC for network-account deployment submissions, and wires `ntx-builder` to send it when configured. Covers single-tx and batch submission paths, validates operator-supplied auth config cleanly at startup, and adds the future node CLI surface for RPC network-tx auth settings.
kkovaacs
force-pushed
the
krisztian/allow-network-transactions
branch
from
46dd83f to
452915a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds optional internal auth-header support to the shared gRPC client builder, enforces that header in RPC for network-account deployment submissions, and wires
ntx-builderto send it when configured. The default name of the header isx-miden-network-tx-auth.Covers single-tx and batch submission paths, validates operator-supplied auth config cleanly at startup, and adds the future node CLI surface for RPC network-tx auth settings.
Adds the following CLI option to
miden-node fullandmiden-nodesequencer:And
miden-ntx-buildergets added the following new CLI option:Closes #2131