chore: spawn actors after sync#2144
Merged
Mirko-von-Leipzig merged 3 commits intoMay 27, 2026
Merged
Conversation
SantiagoPittella
added
the
no changelog
SantiagoPittella
force-pushed
the
santiagopittella-ntx-builder-block-sub-phase-2
branch
from
b27ba78 to
207b4eb
Compare
Comment on lines
+147
to
+149
| for account_id in pending_accounts { | ||
| self.coordinator.spawn_actor(account_id); | ||
| } |
Collaborator
There was a problem hiding this comment.
We should retain a database connection permanently in this event loop.
Otherwise we run the risk that actors will hold all connections in the pool, starving the main loop.
Collaborator
Author
There was a problem hiding this comment.
I created a pinned connection for this
Mirko-von-Leipzig
approved these changes
May 27, 2026
Collaborator
Author
|
@Mirko-von-Leipzig should I wait for another review? |
Mirko-von-Leipzig
approved these changes
May 27, 2026
Collaborator
Mirko-von-Leipzig
left a comment
Mirko-von-Leipzig
left a comment
There was a problem hiding this comment.
I think lets merge, we don't have the review capacity unfortunately.
Mirko-von-Leipzig
deleted the
santiagopittella-ntx-builder-block-sub-phase-2
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Second PR of the
ntx-builderblock-subscription refactor. PR 1 left the actors deactivated behind a subscription-driven sync loop. This PR reintroduces the actor lifecycle driven by committed blocks.The builder now runs three steps:
The coordinator is now a pure lifecycle owner (handle_committed_block) with the old mempool-shape write_event/send_targeted removed, and chain state is shared with actors via
Arc<SharedChainState>.Actors here are lifecycle-only: an actor waits for its account to be committed locally, then idles on notify/timeout. No transactions are built or submitted yet (will be reconnected in PR 3).