[已重新提PR，待Review] fix: Fix some code reading incorrect attribute names#5188
Closed
wangliang181230 wants to merge 9 commits into1Panel-dev:v2from
Closed
[已重新提PR，待Review] fix: Fix some code reading incorrect attribute names#5188wangliang181230 wants to merge 9 commits into1Panel-dev:v2from
wangliang181230 wants to merge 9 commits into1Panel-dev:v2from
Conversation
|
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
wangliang181230
commented
Apr 27, 2026
| source_type=FileSourceType.APPLICATION.value if application_id else FileSourceType.KNOWLEDGE.value if knowledge_id else FileSourceType.APPLICATION.value, | ||
| source_id=application_id or tool_id or knowledge_id, | ||
| source_type=FileSourceType.APPLICATION.value if application_id else FileSourceType.KNOWLEDGE.value if knowledge_id else FileSourceType.TOOL.value, | ||
| source_id=application_id or knowledge_id or tool_id, |
Contributor
Author
There was a problem hiding this comment.
- 修正错误的
source_type，最后一个else后为TOOL类型 - 调整source_id的变量顺序，与source_type的判断顺序保持一致，使代码更加清晰。
wangliang181230
commented
Apr 29, 2026
| end_str = "".join( | ||
| [message[index] for index in | ||
| range(message_len - (int(post_len) if pre_len < max_post_len else max_post_len), message_len)]) | ||
| range(message_len - (post_len if post_len < max_post_len else max_post_len), message_len)]) |
Contributor
Author
There was a problem hiding this comment.
- 是post_len，不是pre_len
- post_len已经是int型的，不需要再转换
Contributor
Author
|
已经 rebase 了 |
Contributor
Author
|
see #5220 |
wangliang181230
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it?
fix: Fix some code reading incorrect attribute names
Summary of your change
修复一些代码读取了错误的属性的问题，感觉都是一些不小心写错的情况。
Please indicate you've done the following: