-
Notifications
You must be signed in to change notification settings - Fork 0
[FEATURE] 공유하기로 전달된 링크 자동 입력 #39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,59 @@ | ||
| import { useAuth } from '@clerk/expo'; | ||
| import { router, useSegments } from 'expo-router'; | ||
| import { useShareIntentContext } from 'expo-share-intent'; | ||
| import { useEffect, useRef } from 'react'; | ||
|
|
||
| import { getSharedUrlFromIntent } from '@/utils/shared-url'; | ||
|
|
||
| export function ShareIntentRouter() { | ||
| const { isLoaded, isSignedIn } = useAuth(); | ||
| const segments = useSegments(); | ||
| const { error, hasShareIntent, isReady, resetShareIntent, shareIntent } = | ||
| useShareIntentContext(); | ||
| const handledUrlRef = useRef<string | null>(null); | ||
|
|
||
| useEffect(() => { | ||
| if (error) { | ||
| console.warn('Failed to read share intent.', error); | ||
| } | ||
| }, [error]); | ||
|
|
||
| useEffect(() => { | ||
| if (!hasShareIntent) { | ||
| handledUrlRef.current = null; | ||
| return; | ||
| } | ||
|
|
||
| if (!isLoaded || !isReady) { | ||
| return; | ||
| } | ||
|
|
||
| if (!isSignedIn) { | ||
| return; | ||
| } | ||
|
|
||
| if (segments[0] !== '(tabs)') { | ||
| return; | ||
| } | ||
|
|
||
| const sharedUrl = getSharedUrlFromIntent(shareIntent); | ||
|
|
||
| if (!sharedUrl) { | ||
| resetShareIntent(true); | ||
| return; | ||
| } | ||
|
|
||
| if (handledUrlRef.current === sharedUrl) { | ||
| return; | ||
| } | ||
|
|
||
| handledUrlRef.current = sharedUrl; | ||
| router.replace({ | ||
| pathname: '/(tabs)/(home)/add-link', | ||
| params: { sharedUrl }, | ||
| }); | ||
| resetShareIntent(true); | ||
| }, [hasShareIntent, isLoaded, isReady, isSignedIn, resetShareIntent, segments, shareIntent]); | ||
|
|
||
| return null; | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
현재코드:
제안:
동작은 동일하고, resetShareIntent를 한 곳에서만 처리해 의도가 더 명확지지 않을까 합니다.
큰 문제는 아니고 가독성 향상을 위한 제안이라 반영할지 넘길지 판단만 해주시면 될 거 같습니다.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
좋은 제안 감사합니다. 말씀해주신 대로 share intent가 있는 경우에는 URL 추출 성공 여부와 관계없이 소비한 intent를 정리하는 흐름이라,
resetShareIntent(true)를 분기 밖에서 한 번만 처리하도록 반영했습니다.이렇게 하니 중복도 줄고, 공유 인텐트를 처리한 뒤 정리한다는 의도가 더 명확해지는 것 같습니다.