Skip to content

set correctionTypes as optional dependency in CorrectionTypeServiceImpl#501

Open
saschaszott wants to merge 1 commit into4Science:main-crisfrom
saschaszott:patch-58
Open

set correctionTypes as optional dependency in CorrectionTypeServiceImpl#501
saschaszott wants to merge 1 commit into4Science:main-crisfrom
saschaszott:patch-58

Conversation

@saschaszott
Copy link

Problem Description

This PR fixes a bug which is caused by a missing dependency in CorrectionTypeServiceImpl. We see this error on application startup:

2025-02-26 11:47:17 Field correctionTypes in org.dspace.correctiontype.service.impl.CorrectionTypeServiceImpl required a bean of type 'java.util.List' that could not be found.
2025-02-26 11:47:17 
2025-02-26 11:47:17 The injection point has the following annotations:
2025-02-26 11:47:17     - @org.springframework.beans.factory.annotation.Autowired(required=true)
2025-02-26 11:47:17 
2025-02-26 11:47:17 
2025-02-26 11:47:17 Action:
2025-02-26 11:47:17 
2025-02-26 11:47:17 Consider defining a bean of type 'java.util.List' in your configuration.
2025-02-26 11:47:17 

The required dependency should be transformed to an optional dependency since core-services.xml does not contain a correctionTypes list.

@saschaszott
Copy link
Author

@jor4science, this is production-critical. The changes should be merged into DSC 2024.02.01.

@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had
activity in one year. It will be closed in 14 days if no further activity occurs.

Allowing pull requests to close as stale helps us filter out old work that is no longer
relevant and helps developers focus on reviewing current work.

All pull requests closed by this bot act like normal pull requests;
they can be searched for, commented on or reopened at any point.

If these changes are still relevant then please comment and/or rebase your PR based on the
latest DSpace code. This will remove the stale status and notify us to assign a reviewer
for your PR.

@github-actions github-actions bot added the stale label Mar 15, 2026
@saschaszott
Copy link
Author

@jor4science , do you have any updates on this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant