Repository navigation
Bug fixes for API Documentation - #136
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
A critical issue remains with service-worker registration for the deployed app path.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 1
What changed in this PR
Fixes API documentation generation and supports libOpenCOR demos with GitHub Pages cross-origin isolation.
Changes:
- Handles missing component type metadata.
- Adds reusable libOpenCOR Vite integration.
- Adds service-worker isolation and layout fixes.
| File | Reviewed changes |
|---|---|
vuese-generator.js |
Handles incomplete type metadata. |
vite.config.js |
Uses the shared libOpenCOR plugin. |
vite-plugin-libopencor.js |
Serves and copies libOpenCOR assets. |
docs/public/coi-serviceworker.js |
Adds cross-origin isolation support. |
docs/.vitepress/config.js |
Configures docs build and service-worker registration. |
docs/.vitepress/theme/custom.css |
Applies consistent box sizing. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
alan-wu
approved these changes
Sep 24, 2026
alan-wu
left a comment
Member
There was a problem hiding this comment.
Thanks, it looks good to me. This seems to be the way to add the headers into the github pages.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

When rendering the demo apps in GitHub pages, there are some Cross-origin issues, and the
libOpenCORplugin is missing. Those are also fixed.The updates can be tested on https://akhuoa.github.io/simulationvuer/.
The app on GitHub Pages (https://akhuoa.github.io/simulationvuer/app/#/) is now working as well.