avmenc.c: Misc cleanup for config->arg_ctrls#5027
Merged
urvangjoshi merged 1 commit intoJun 3, 2026
Merged
Conversation
Document that the current value of the ARG_CTRL_CNT_MAX macro doesn't really make sense. Handle invalid indexes for the config->arg_ctrls array rather than assert the indexes are valid. Use the pre-increment ++ operator on config->arg_ctrl_cnt consistently. When adding AVME_SET_QP to the config->arg_ctrls array, look for an existing array element rather than always insert at the end of the array.
wantehchang
commented
Jun 3, 2026
urvangjoshi
approved these changes
Jun 3, 2026
wantehchang
commented
Jun 3, 2026
| const int qp_val = | ||
| get_qindex_from_quantizer_and_warn(cq_level_val, "cq-level", "qp"); | ||
| const int idx = config->arg_ctrl_cnt; | ||
| assert(idx < (int)ARG_CTRL_CNT_MAX); |
Member
Author
There was a problem hiding this comment.
Note that it is not necessary to cast ARG_CTRL_CNT_MAX to int because the NELEMENTS macro already contains an int cast.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Document that the current value of the ARG_CTRL_CNT_MAX macro doesn't really make sense.
Handle invalid indexes for the config->arg_ctrls array rather than assert the indexes are valid.
Use the pre-increment ++ operator on config->arg_ctrl_cnt consistently.
When adding AVME_SET_QP to the config->arg_ctrls array, look for an existing array element rather than always insert at the end of the array.