Improve image load error messages#632
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR standardizes image load/store error reporting to use print_error() (stderr) and aligns several messages to a more consistent, format-specific wording convention across the CLI image loaders.
Changes:
- Updated TinyEXR/STB/Wuffs image-load failure messages to a consistent
"ERROR: ... failed 'file'"style. - Switched
.ktxand.ddsloader failures fromprintf(stdout) toprint_error(stderr) and updated message wording. - Updated changelog to reflect stderr reporting improvements for
.dds/.ktxfailures.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| Source/astcenccli_image_load_store.cpp | Standardizes error output to stderr and revises wording across EXR/STB/KTX/DDS/ASTC loaders. |
| Source/astcenccli_image_external.cpp | Aligns Wuffs-related error wording and file-open failures to the new convention. |
| Docs/ChangeLog-5x.md | Documents stderr reporting fix for .dds and .ktx load errors. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure all image_load error messages use print_error and follow a standard wording convention.
Fixes #629