Skip to content

ci: add nightly Linux® brick tests - #12

Open
federicobozzini wants to merge 4 commits into
mainfrom
nightly-linux
Open

federicobozzini wants to merge 4 commits into
mainfrom
nightly-linux

Conversation

@federicobozzini

Copy link
Copy Markdown
Contributor

No description provided.

Signed-off-by: Federico Bozzini <federico.bozzini@arm.com>
@federicobozzini
federicobozzini requested a review from a team as a code owner November 16, 2026 14:51
Comment thread .github/workflows/nightly.yml Outdated
Comment on lines +43 to +45
sudo apt-get install -y --no-install-recommends \
build-essential clang-18 lld-18 ninja-build pkg-config python3-dev \
libsndfile1 libportaudio2

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need libportaudio2 to be installed

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed 7744af5

Comment thread .github/workflows/nightly.yml Outdated
tts:qwen3-tts
# FLUX.2 Klein tests are disabled until the models are publicly available.
# image_generation:flux2-klein-generation
# Phonon is excluded until its models are public; this suite tests pocket-tts-en only.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can remove since now it is public

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

object_detection:yolo
tts:qwen3-tts
# FLUX.2 Klein tests are disabled until the models are publicly available.
# image_generation:flux2-klein-generation

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can uncomment since now the model is public

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The model is public, but the test definition also references flux2_klein_generation_4step_manifest.json, which is missing from the pinned model package. Enabling FLUX would therefore fail nightly. Let’s address this mismatch separately and enable FLUX once it’s resolved if it's OK with you.

ln -s "$COMPUTE_FLOW_HOME" "$COMPUTE_FLOW_TEST_MODEL_HOME"
- name: Configure generated brick tests
run: |
uv run cmake -S . -B build \

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a TODO to say that we should build the bricks with the brick manager?

compute-flow build native

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

run: |
cache=build/CMakeCache.txt
grep -qx 'COMPUTE_FLOW_USE_PREBUILT_DEPS:BOOL=ON' "$cache"
for dependency in PROTOBUF LITERT EXECUTORCH ONNXRUNTIME MNN SENTENCEPIECE; do

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add a TODO to check whether this part can be removed?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

run: |
set -euo pipefail
export PYTHONPATH="$GITHUB_WORKSPACE/build/python${PYTHONPATH:+:$PYTHONPATH}"
bricks=(

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a TODO to discover the available brick rather than manually maintain a list. Otherwise, we require to update this for each new developed brick

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Signed-off-by: Federico Bozzini <federico.bozzini@arm.com>
Signed-off-by: Federico Bozzini <federico.bozzini@arm.com>
Signed-off-by: Federico Bozzini <federico.bozzini@arm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants