Repository navigation
fix(src): 修复密伶之径账号配置无法加载和保存 - #1987
Merged
jinghero merged 1 commit intoNov 14, 2026
Merged
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Contributor
Author
总体结论:可以合并宝宝,这次把密伶之径补回了现有配置链,没有靠重置关卡来绕过校验,修得对喵。旧配置加载、保存和下发使用同一个关卡标识;页面选项与当前关卡标签也共用一份映射,少了一处漏改的机会。 dot酱核对了相关源码和新增回归测试,没有发现必须修改项。这里是静态审查,未运行真实游戏;实际刷取仍由 SRC 负责。 —— 帮你守住原关卡选择的 dot酱敬上 🐾 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
摘要
Closes #1954
验证
测试提交:
d59515c3ee216f59d6969c53ac2ac076c9294cc8,Windows、Python 3.12.10,依赖由uv.lock锁定。python -m pytest tests/task/test_src_stage_config.py -q:修复前 2 项失败,修复后 2 项通过。覆盖已有 YAML、旧 JSON 转换、配置输入输出、完整回传、修改其他字段后的保存、文件回读和重新加载;关卡始终保留原标识,包含原生来源且关闭覆写的账号。Dungeon.Name和NameAtDoubleRelic均为Cavern_of_Corrosion_Path_of_the_Secret_Actor。python -m pytest tests -q:2087 通过、1 失败、1 跳过,另有 17 个子测试通过。唯一失败为test_switch_preserves_user_data_and_confirms_complete_tree的临时工作区清理断言;同一用例单独复跑通过。未修改基准7af5238026204f0e827749e8b6c44a4557dc3d82在相同依赖和环境下完整回归为 2086 通过、1 跳过、17 个子测试通过,也未复现该失败。未找到本次改动影响该清理链的路径;首次失败原因尚未确诊,保留该记录,不将全量检查描述为全部通过。yarn test:361 项通过;yarn lint、yarn typecheck、yarn format:check和yarn audit:i18n --check均通过。Lint 的队列组件默认值警告已在未修改的前端基准上复现。uv lock --check检查通过。新增两条配置回归和三语组件渲染回归随实现保留。关卡组件由 861 行缩至 826 行,属于局部维护;保存遥测复用现有账号保存入口。
未运行真实游戏、完整浏览器交互或安装包验证。