Repository navigation
[Backport version-16-hotfix] feat: clear dependency results, task links and date-only schedules - #42
Merged
Conversation
(cherry picked from commit 3181b3b)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #41 to
version-16-hotfix.Link and Unlink now show a persistent result panel plus native Desk alerts. Report links created, links already existing and left unchanged, dependencies removed, attempts with no existing dependencies, and failed operations. APIs return per-relationship outcome details. Replaces invisible toast calls that had no mounted toast renderer.
Task names and dependency references open native Task forms in new tabs using Frappe's route helper. Both Predecessors and Successors appear beside Task Name, showing relationship type and lag/lead. Start and Finish show date only using Desk's date format; stored timestamps are retained.
A visible scheduling notice explains that saving dependencies runs ERPNext validation/scheduling hooks and can change dates/times, that existing links remain unchanged, and that unlinking does not restore prior dates. After saving, compare loaded task schedules before and after refresh and report actual changes, zero changes, or a failed refresh. This does not add a new scheduling engine; dependency type and lag/lead behavior still depends on installed hooks.
Validation: 6 UI interaction tests and 17 backend tests pass; Python compilation, production frontend build, and diff checks pass. Tests cover successful/no-op/error feedback, schedule change detection, clickable task routes, dependency columns, and date-only values. API transport is mocked in UI tests; the live site has not been tested.
Deployment: rebuild frontend assets and reload Desk. Backport to version-16-hotfix.