Repository navigation
docs(spark): removing a Spark build on AWS is not a data loss (forge-cli #1007) - #266
Merged
Merged
Conversation
…cli #1007) The data-loss gate no longer counts what a removed build ran with. A stream's dead-letter table still counts.
4 of 8 tasks
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Documents forge-cli #1007, on
main(3a390592) after the 0.33.0 cut and in no release: removing a Spark build on AWS is no longer a data loss for the data-loss gate offluid apply.advanced/spark-iceberg-aws.md, "When a build leaves the contract": what the gate no longer counts (the build's runner and job config, jar copies, log group, role and policies, Glue job and connection, the product's own EMR Serverless application, the scheduler policy, the log key, the Lake Formation registration role), the linefluid plan --tofuandfluid applyprint for them, what still counts (an output table, a bucket, a bucket's own key, and a stream's dead-letter table, which goes with its build), the refusal and its count, and the fail-closed rule.cli/apply.md, "OpenTofu data-loss gate": one paragraph, since the list there is by resource type and this exemption is by type and by the end of the name.upgrading.md: one bullet under "Not in a release yet".Related CLI PRs
Areas Updated
Decisions
*On forge-climain, not yet in a release ([forge-cli #1007](...)).*: the pull request merged after the 0.33.0 cut. The pin stays at 0.32.0.tofurun: they are forge-cli's plan review (the codefluid plan --tofuandfluid applyrun aftertofu plan), given as the plan's deletes the resources that the page's example contract adds to the module with its build, computed the way forge-cli's own test computes them, and for the second output the contract's output table. The text says so. No state or AWS call was involved.sink: table) still needs--allow-data-loss: the build adds that table, and it goes with the build. The first sentence of the section, theapply.mdparagraph and the upgrading bullet say "unless the build has a dead-letter table", and a run shows the table as gated.fluid plan --tofuwarns that the apply will refuse, and does not refuse itself; the text says so.Checklist
python scripts/check_cli_docs.py(with forge-cli's liveCHANGELOG.md),check_providers.pyandgen_contract_reference.py --checkpassNotes
apply.mdparagraph did not name the log key next to its "a product's KMS key counts" sentence.mainequals the code the text was written and reviewed against (the pull request's head984a06de) for all five files it touches.main(docs(spark): fluid apply stops a removed build's runs before it destroys what they run with (forge-cli #1008) #265) is the base.