Repository navigation
docs(dbt): fluid apply runs a build whatever its trigger, finds the dbt that has its adapter, and pins the container (forge-cli #1009) - #269
Merged
Conversation
…bt that has its adapter, and pins the container (forge-cli #1009) Which dbt apply runs, the pinned container and its refusals, the three variables, the trigger types, and the upgrade bullets.
…t-wave16 # Conflicts: # docs/upgrading.md
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Documents forge-cli #1009, on
main(caf4306d) after the 0.33.0 cut and in no release:fluid applyruns a dbt or Python build whatever its trigger type, finds the dbt that has the build's adapter by dbt's plugin name, and pins the dbt container fallback.cli/generate.md: the paragraph about the container fallback now says what it did up to 0.33.0, and a new section, "Which dbtfluid applyruns", covers which dbt a build gets ($DBT_EXECUTABLE, the local dbt and its plugin name, Fusion), the container (the image pinned by digest, the packages pinned exactly and installed from wheels only, the isolated pip, thedocker runcommand, the table of pinned adapters), the three variables with the refusals of a tag, a range and an adapter with no pin, and the AWS adapters (what is not passed into the container and the two refusals beforedockerstarts).advanced/environment-variables.md: theDBT_DOCKER_IMAGE,DBT_BOOTSTRAP_IMAGEandDBT_ADAPTER_PACKAGErows.advanced/airflow.md: one bullet in "What the DAG does": the trigger types thatfluid applyruns once, with the output of 0.33.0 and ofmainfor aschedule_and_datasetbuild.upgrading.md: three bullets under "Not in a release yet".Related CLI PRs
Areas Updated
Decisions
*On forge-climain, not yet in a release ([forge-cli #1009](...)).*: the pull request merged after the 0.33.0 cut. The pin stays at 0.32.0.cli/generate.mdand three rows of the environment variables page, so the new section sits beside that paragraph.fluid applycalls for a dbt build) with stand-ins for the local dbt's--versionoutput and fordocker, run on 0.33.0's code and onmainfor the trigger blocks, and onmainfor the container command and the refusals. The pins of the table are read from the code. Whether the pinned packages resolve on PyPI is the pull request's own record (a comment in the code); it was not run here.$DBT_EXECUTABLEis used as it is, whatever adapter it has, so the page says so. The reviewer found that an earlier draft put it first in an order whose every step checks the adapter.glue) runs in a container withDBT_ADAPTER_PACKAGEor withDBT_DOCKER_IMAGE, and the AWS credential checks come before the missing-pin refusal, so a reader without keys meets the credentials message first. The page and the bullet say so.Checklist
python scripts/check_cli_docs.py(with forge-cli's liveCHANGELOG.md),check_providers.pyandgen_contract_reference.py --checkpassNotes
$DBT_EXECUTABLEorder, dbt Fusion and the plugin match, thegluecontainer (twice), the Redshift password case in the upgrading bullet, the DAG that does not decide when foreventandtimetablebuilds, and a message that names no field.mainequals the code the text was written and reviewed against (the pull request's head6038b436) for every file but the changelog.main(docs(spark): a run starts only on the job config fluid apply compiled (forge-cli #1014) #268) is merged in.