Repository navigation
docs(aws): an Iceberg table on Glue plans no change after an engine commits to it (forge-cli #1012) - #273
Merged
Conversation
…ommits to it (forge-cli #1012) The location is emitted as Iceberg keeps it, without the trailing slash.
…ark-aws-wave19 # Conflicts: # docs/upgrading.md
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Documents forge-cli #1012, on
main(92b7c8ef) after the 0.33.0 cut and in no release: an Iceberg table's Glue location is emitted without the trailing slash, as Iceberg keeps it, so a re-apply after an engine's commit plans no change.providers/aws.md, "Iceberg tables in Glue": one paragraph (the form of the location, why the slash made each plan after a commit update the table, the two plan lines before and after, and what the first apply after the upgrade does).upgrading.md: one bullet under "Not in a release yet".Related CLI PRs
Areas Updated
Decisions
*On forge-climain, not yet in a release ([forge-cli #1012](...)).*: the pull request merged after the 0.33.0 cut. The pin is 0.33.0.tofu plan: +0 ~1 -0after an Iceberg-style commit on the code before the change, and+0 ~0 -0on the code of the pull request. The shipped test fails on the old code at its first assertion, on the location with its slash, so the first line comes from a copy of the test with that assertion turned into a print. The text says "run as forge-cli's own test of it plays it".mainbranch (LocationUtil.stripTrailingSlash,TableMetadata,GlueTableOperations), not on a release tag.Checklist
python scripts/check_cli_docs.py(with forge-cli's liveCHANGELOG.md, against the 0.33.0 CLI),check_providers.pyandgen_contract_reference.py --checkpassNotes
mainequals the code the text was written and reviewed against (the pull request's head4c8ac13f) for every code file.main(docs(spark): a dead stream restarts within a budget, fluid apply --mode reconcile keeps streams running, and a destroy waits for a starting application (forge-cli #1013, #1017) #272) is the base.