Skip to content

docs(aws): an Iceberg table on Glue plans no change after an engine commits to it (forge-cli #1012) - #273

Merged
fas89 merged 2 commits into
mainfrom
claude/docs-spark-aws-wave19
Nov 19, 2026
Merged

fas89 merged 2 commits into
mainfrom
claude/docs-spark-aws-wave19

Conversation

@fas89

@fas89 fas89 commented Nov 19, 2026

Copy link
Copy Markdown
Collaborator

Summary

Documents forge-cli #1012, on main (92b7c8ef) after the 0.33.0 cut and in no release: an Iceberg table's Glue location is emitted without the trailing slash, as Iceberg keeps it, so a re-apply after an engine's commit plans no change.

  • providers/aws.md, "Iceberg tables in Glue": one paragraph (the form of the location, why the slash made each plan after a commit update the table, the two plan lines before and after, and what the first apply after the upgrade does).
  • upgrading.md: one bullet under "Not in a release yet".

Related CLI PRs

Areas Updated

  • Getting Started
  • CLI Reference
  • Provider Docs
  • Walkthroughs / Examples
  • Contributing / Community Docs
  • Other: upgrading

Decisions

  • The markers read *On forge-cli main, not yet in a release ([forge-cli #1012](...)).*: the pull request merged after the 0.33.0 cut. The pin is 0.33.0.
  • The two plan lines are real, from forge-cli's own test of the fix run with the real OpenTofu (1.13.1) against a local mock of AWS (moto 5.2.5): tofu plan: +0 ~1 -0 after an Iceberg-style commit on the code before the change, and +0 ~0 -0 on the code of the pull request. The shipped test fails on the old code at its first assertion, on the location with its slash, so the first line comes from a copy of the test with that assertion turned into a print. The text says "run as forge-cli's own test of it plays it".
  • The reviewer found that the changelog's "updates each existing table's location once" is broader than what happens: the plan refreshes the live location first, so a table that an engine has committed to since the last apply has no slash already and plans no change. The page says that.
  • Not covered: Iceberg's source was read on its main branch (LocationUtil.stripTrailingSlash, TableMetadata, GlueTableOperations), not on a release tag.

Checklist

  • python scripts/check_cli_docs.py (with forge-cli's live CHANGELOG.md, against the 0.33.0 CLI), check_providers.py and gen_contract_reference.py --check pass
  • Site build, built-link check, offline link check and the linked anchor pass locally

Notes

…ommits to it (forge-cli #1012)

The location is emitted as Iceberg keeps it, without the trailing slash.
…ark-aws-wave19

# Conflicts:
#	docs/upgrading.md
@fas89
fas89 merged commit 93011f7 into main Nov 19, 2026
9 checks passed

This branch was previously deployed

1 inactive deployment
github-pages — 2865bbb0 Deployed Nov 19, 2026 by fas89 via deploy #429
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant