Repository navigation
docs: every forge-cli change in 0.34.0 reads since 0.34.0, and the releases map is refreshed - #274
Merged
Merged
Conversation
…leases map is refreshed 51 markers of the form on forge-cli main, not yet in a release become since 0.34.0; the section Not in a release yet is Changes in 0.34.0; three sentences that said on main for one of these changes say 0.34.0.
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
forge-cli cut its 0.34.0 changelog entry (forge-cli #1020,
127fa5bfonmain). Thecli-consistencyjob fetches forge-cli'sCHANGELOG.mdfrommain, so since that commit the release-marker sweep inscripts/check_cli_docs.pyfails on docsmainand on every pull request: a marker that says a pull request is not yet in a release names one that is in 0.34.0. This pull request does whatdocs/contributing.mdasks once work ships.*On forge-climain, not yet in a release ([forge-cli #N](...)).*in 7 pages become*(since 0.34.0, [forge-cli #N](...))*: the pull requests #1007, #1008, #1009, #1010, #1012, #1013, #1014, #1015 and #1017.main" for one of these changes now say 0.34.0 (the key of a dead letter sent to a topic, the argv of a local run, and the dbt trigger output inairflow.md). Statements that an output was produced "on forge-climain" are left as they are: they say where the output ran.scripts/forge-cli-releases.jsonis regenerated withpython scripts/check_cli_docs.py --refresh-releases <forge-cli checkout> --refresh-ref origin/main, with forge-climainat127fa5bf: 64 pull requests mapped, reviewed through 0.34.0.upgrading.md: the section "Not in a release yet" is "Changes in 0.34.0", with an intro like the earlier releases'.Decisions
docs/.vuepress/cli-version.jsonnames a release that has to install from PyPI, and the pin bump, the regenerated contract reference pages and the clean-up that follow it belong to the pull request of the pin (as docs: forge-cli 0.33.0 (pin, contract reference, upgrade notes) #271 did for 0.33.0). Asince 0.34.0line passes the version sweep with the pin at 0.33.0, assince 0.33.0did at 0.32.0.Checklist
python scripts/check_cli_docs.pyagainst the 0.33.0 CLI and the changelog of the cut passes: 0 markers left, 0 pending;check_providers.pyandgen_contract_reference.py --checkpassNotes
cli-consistencyis red on every docs pull request, for the same reason.