refactor(tools): split ReadPdf and ReadHtml out of Read tool#155
Merged
Conversation
The Read tool had PDF extraction and HTML conversion baked in, violating SRP and polluting its schema with a `pages` parameter that caused LLM agents to pass empty strings on non-PDF files, triggering repeated failures. - New `loopal-tool-read-pdf` crate: ReadPdf tool with `pages` param - New `loopal-tool-read-html` crate: ReadHtml tool for HTML→text - Read tool now only handles text files (clean schema, no `pages`)
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ReadPdfTool) and HTML reading (ReadHtmlTool) into independent tool cratespagesparameter)pages: ""on non-PDF files, causing repeated failuresChanges
crates/tools/filesystem/read-pdf/—ReadPdfToolwithpagesparamcrates/tools/filesystem/read-html/—ReadHtmlToolfor HTML→text conversioncrates/tools/filesystem/read/— removed PDF/HTML branches andpagesschema fieldcrates/tools/registry/— registers both new toolsTest plan