refactor(tools): TypedTool trait + input/schema normalization#158
Merged
Conversation
…rameter safety Eliminates systemic schema-parameter mismatch by replacing hand-written JSON schemas and manual Value parsing with typed parameter structs (derive Deserialize + JsonSchema). TypedBridge adapter bridges typed tools to dyn Tool registry. Also splits Bash tool into Bash + BashProcess to eliminate flag argument anti-pattern, and adds input/schema normalization (empty string → None, $ref inlining, title/schema removal).
5cce5bd to
455f801
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TypedTool<P>trait +TypedBridgeadapter for compile-time schema-parameter safety — eliminates hand-written JSON schemas and manualValueparsing across all 23 builtin toolsBash(command execution) +BashProcess(process management) to eliminate flag argument anti-patternChanges
crates/loopal-tool-api/src/— new: typed_tool.rs, typed_bridge.rs, input_normalize.rs, schema_normalize.rscrates/tools/process/bash-process/— new crate for BashProcessToolcrates/tools/process/background/src/ops.rs— migrated from bash/bg_ops.rsimpl Tooltoimpl TypedTool<XxxParams>builtin/mod.rsupdated to use TypedBridge registrationTest plan