Repository navigation
Add manual triggers for docker build action - #1117
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discissed in #1116, here I am adding a manual trigger for the docker build action. The idea is that we can do test builds or re-push builds simply by rerunning for a given tag. This will generally incorporate any security updates in base images or packages that we manually update.
I did realize, however, that the
ca-certificatesupdate in this docker image is only in the initial build image, not the final image, so I had to update the docker image to make all of those changes too. My plan (already in progress) is to cherry pick the Docker image update to a new branch for each of the tagged updates, then re-push those tags/rerelease to rebuild the images.