[OCTRL-1081] Wrap kubectl into Mesos executor task#805
Open
justonedev1 wants to merge 6 commits intomasterfrom
Open
[OCTRL-1081] Wrap kubectl into Mesos executor task#805justonedev1 wants to merge 6 commits intomasterfrom
justonedev1 wants to merge 6 commits intomasterfrom
Conversation
knopers8
reviewed
Mar 19, 2026
| // aux.Control.Mode = "direct" | ||
| // } | ||
|
|
||
| aux.Control.Mode = c.Control.Mode.String() |
Collaborator
There was a problem hiding this comment.
There is a change in behaviour for hooks though, no? Before they were getting direct instead of hook, which actually smells like a bug, but perhaps something is relying on it?
Collaborator
Author
There was a problem hiding this comment.
This is probably my misunderstanding, as I thought that it is a bug to implicitly change hook to direct.. especially when we have hooktask that is created only if controlmode.HOOK is present.
see
Collaborator
There was a problem hiding this comment.
then perhaps extract the bugfix to a separate PR and we can validate it.
knopers8
reviewed
Apr 17, 2026
user infor setup properly... kubectl passes arguments properly to the kubernetes attempt for fairmq bla
knopers8
reviewed
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The task description is in the documentation
docs/kubernetes_ecs.md