Skip to content

fix: keep MCP server setting values out of the Amazon Q log - #240

Merged
dungdong-aws merged 1 commit into
Amazon-Q-Developer:feature/dungdongfrom
dungdong-aws:fix/chat-message-log-mcp-values
Nov 18, 2026
Merged

dungdong-aws merged 1 commit into
Amazon-Q-Developer:feature/dungdongfrom
dungdong-aws:fix/chat-message-log-mcp-values

Conversation

@dungdong-aws

Copy link
Copy Markdown
Contributor

No description provided.

@dungdong-aws
dungdong-aws marked this pull request as ready for review November 16, 2026 20:23
@dungdong-aws
dungdong-aws requested a review from a team as a code owner November 16, 2026 20:23
@@ -0,0 +1,4 @@
{
"type": "Bug Fix",
"description": "The Amazon Q log lists MCP server environment variable and header names without their values"

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need this changeLog

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed it

@dungdong-aws
dungdong-aws force-pushed the fix/chat-message-log-mcp-values branch from e5d699f to cada9ca Compare November 17, 2026 22:24
@dungdong-aws
dungdong-aws changed the base branch from main to feature/dungdong November 17, 2026 22:48
@dungdong-aws dungdong-aws changed the title fix: log MCP server env variable and header names without their values fix: keep MCP server setting values out of the Amazon Q log Nov 17, 2026
@dungdong-aws
dungdong-aws force-pushed the fix/chat-message-log-mcp-values branch from cada9ca to 877551a Compare November 17, 2026 23:19
The chat webview message log keeps MCP settings messages with the values
of the name, transport, scope, timeout and command fields and tool
permission choices. The URL keeps only its origin, arguments keep only
flag names, env variables and headers keep only their names, and other
field values are hidden. Other messages are logged as before.
@dungdong-aws
dungdong-aws force-pushed the fix/chat-message-log-mcp-values branch from 877551a to fc8cecd Compare November 17, 2026 23:23
@github-actions

Copy link
Copy Markdown
  • This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
    • Note: beta or "experiment" features that have active users should announce fixes in the changelog.
    • If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

@dungdong-aws
dungdong-aws merged commit 7ad0e57 into Amazon-Q-Developer:feature/dungdong Nov 18, 2026
18 checks passed
dungdong-aws added a commit that referenced this pull request Nov 19, 2026
* fix: read developer override settings from user settings only (#230)

* fix(amazonq): read developer override settings from user settings only

* fix(amazonq): scope packaged developer settings

* fix(amazonq): use extension mode for dev overrides

* fix(amazonq): defer developer settings until activation

* fix(amazonq): own developer settings lifecycle

* fix(amazonq): scope developer settings in manifest

* fix: show code issue text as plain text in hovers and tooltips (#231)

* fix(amazonq): show code issue text as plain text in hovers and tooltips

* fix(amazonq): keep code issue text wrapping between words in hovers and tooltips

MarkdownString.appendText turns every space into  , so long finding text
could only wrap mid-word. Escape the text with a helper that keeps spaces.

* fix: keep MCP server setting values out of the Amazon Q log (#240)

The chat webview message log keeps MCP settings messages with the values
of the name, transport, scope, timeout and command fields and tool
permission choices. The URL keeps only its origin, arguments keep only
flag names, env variables and headers keep only their names, and other
field values are hidden. Other messages are logged as before.

* fix: open only http and https links from chat (#232)

* fix(amazonq): open only http and https links from chat

* fix: validate external language server links

* fix: preserve validated external link queries

* test: stub external link confirmation directly

* test: inject external link opener

* fix(amazonq): open validated language-server web links without an extra prompt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants