Repository navigation
fix(amazonq): limit workspace agent config permissions to servers in its folder - #3062
Draft
laileni-aws wants to merge 2 commits into
Draft
laileni-aws wants to merge 2 commits into
laileni-aws wants to merge 2 commits into
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
laileni-aws
force-pushed
the
fix/mcp-workspace-permissions
branch
from
November 17, 2026 04:23
0abc7d7 to
1091fa4
Compare
…its folder A workspace agent config, or a workspace mcp.json, now applies server permissions and default enablement only to the MCP servers that it defines: a '*' in its tools enables only those servers, and its other glob entries and its entries for other servers are skipped. A skipped entry that names a loaded server is logged. A workspace file does not load a server whose name has a glob character. A permission entry that is not a string is skipped in every agent config. Adds tests.
…er name has a glob character A workspace mcp.json server whose name has '*' or '?' is now skipped before the duplicate check, so it no longer replaces a global mcp.json server that has the same key. Server names lose '*' and '?' when they become keys, so 'tracker*' and 'tracker' have the same key. The default enablement of a legacy mcp.json server no longer has a fallback for a server without a config file path, which every legacy server has. Adds tests for this, for permission entries across two workspace folders, and for a server whose config file or original name is not known.
laileni-aws
changed the base branch from
feature/security-fixes-v2
to
feature/laileni-fixes
November 18, 2026 20:38
laileni-aws
force-pushed
the
fix/mcp-workspace-permissions
branch
from
November 18, 2026 20:38
fc52861 to
fb5d76d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.