Repository navigation
fix(amazonq): log errors from chat notification handlers - #3063
Draft
laileni-aws wants to merge 2 commits into
Draft
laileni-aws wants to merge 2 commits into
laileni-aws wants to merge 2 commits into
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
laileni-aws
force-pushed
the
fix/chat-notification-errors
branch
from
November 17, 2026 04:23
2503190 to
a2637f7
Compare
The chat server and the agentic chat server now log an error from a notification handler, and from the background code symbol update, instead of leaving an unhandled rejection. A rule request with no workspace folder open now creates a saved prompt. Adds tests.
… string form The agentic chat controller formats the failure of its background code symbol update with formatErr, so a reason with no string form is logged too. A reason that cannot be formatted is dropped instead of becoming an unhandled rejection. The insert notification test of the older chat server now makes the document read of the controller fail.
laileni-aws
changed the base branch from
feature/security-fixes-v2
to
feature/laileni-fixes
November 18, 2026 20:38
laileni-aws
force-pushed
the
fix/chat-notification-errors
branch
from
November 18, 2026 20:38
c685dfd to
6ff701c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.