Skip to content

fix(amazonq): log errors from chat notification handlers - #3063

Draft
laileni-aws wants to merge 2 commits into
Amazon-Q-Developer:feature/laileni-fixesfrom
laileni-aws:fix/chat-notification-errors
Draft

laileni-aws wants to merge 2 commits into
Amazon-Q-Developer:feature/laileni-fixesfrom
laileni-aws:fix/chat-notification-errors

Conversation

@laileni-aws

Copy link
Copy Markdown
Collaborator

No description provided.

@codecov-commenter

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@laileni-aws
laileni-aws force-pushed the fix/chat-notification-errors branch from 2503190 to a2637f7 Compare November 17, 2026 04:23
The chat server and the agentic chat server now log an error from a notification handler, and
from the background code symbol update, instead of leaving an unhandled rejection. A rule request
with no workspace folder open now creates a saved prompt.

Adds tests.
… string form

The agentic chat controller formats the failure of its background code symbol update with
formatErr, so a reason with no string form is logged too. A reason that cannot be formatted is
dropped instead of becoming an unhandled rejection. The insert notification test of the older chat
server now makes the document read of the controller fail.
@laileni-aws
laileni-aws changed the base branch from feature/security-fixes-v2 to feature/laileni-fixes November 18, 2026 20:38
@laileni-aws
laileni-aws force-pushed the fix/chat-notification-errors branch from c685dfd to 6ff701c Compare November 18, 2026 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants