Repository navigation
fix(amazonq): remove invisible characters from chat requests - #3064
Draft
laileni-aws wants to merge 3 commits into
Draft
laileni-aws wants to merge 3 commits into
laileni-aws wants to merge 3 commits into
Conversation
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
laileni-aws
force-pushed
the
fix/chat-invisible-characters
branch
from
November 17, 2026 04:23
b2c7a9f to
d557b76
Compare
sanitizeInput now also removes the Unicode default ignorable characters, such as the variation selectors, but keeps a presentation selector that belongs to an emoji. sanitizeRequestInput now also applies to inline chat, memory bank and chat server requests, and to the keys of objects. Adds tests.
…hema The chat request removes invisible characters from object keys, so the model gets the property names of an MCP tool's input schema without them. Before the agentic chat controller runs an MCP tool, it now gives each key of the tool input back the property name of the tool's input schema, so the tool gets the input that its schema describes. restorePropertyNames follows properties, additionalProperties, items, prefixItems, allOf, anyOf, oneOf and $ref pointers within the schema. A key keeps its name when it stands for no property name or for more than one, or when another key of the same object already has that name. The conversation keeps the tool input as the model wrote it.
…ored from restorePropertyNames looks at no more than 1024 schema entries for one value, repeated and non-schema entries included, and reads them with an index. sanitizeKeys returns the keys as they are when none changes. Adds tests of both limits and updates the sanitizeInput comment.
laileni-aws
changed the base branch from
feature/security-fixes-v2
to
feature/laileni-fixes
November 18, 2026 20:38
laileni-aws
force-pushed
the
fix/chat-invisible-characters
branch
from
November 18, 2026 20:38
80737df to
b14552e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.