Skip to content

fix(amazonq): require approval of the configuration that an MCP registry server starts with - #3068

Draft
laileni-aws wants to merge 2 commits into
Amazon-Q-Developer:feature/laileni-fixesfrom
laileni-aws:fix/mcp-registry-consent
Draft

laileni-aws wants to merge 2 commits into
Amazon-Q-Developer:feature/laileni-fixesfrom
laileni-aws:fix/mcp-registry-consent

Conversation

@laileni-aws

Copy link
Copy Markdown
Collaborator

No description provided.

@codecov-commenter

codecov-commenter commented Nov 16, 2026 •

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 96.93356% with 18 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...anguage-server/agenticChat/tools/mcp/mcpManager.ts 95.73% 12 Missing and 1 partial ⚠️
...ge-server/agenticChat/tools/mcp/mcpEventHandler.ts 98.39% 3 Missing ⚠️
chat-client/src/client/mcpMynahUi.ts 92.85% 1 Missing ⚠️
...ge-server/agenticChat/tools/mcp/mcpConsentStore.ts 98.27% 0 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

@laileni-aws
laileni-aws force-pushed the fix/mcp-registry-consent branch from d635c1f to 26f0035 Compare November 17, 2026 04:23
…try server starts with

Install from the MCP registry now shows the command, arguments, environment variables, URL and
headers of the server before it installs the server. A registry server asks for approval before
it starts with a configuration that the user has not approved, including once for a server that
was installed before this change. The registry sync asks before it replaces an approved server,
and it does not reinstall a server that the user turned off. The consent prompt shows the
package index of a server, and the URLs in its command without a user name or password.

Adds tests.
…apes

The consent prompt of an MCP server shows control, format, private use and unassigned characters,
the braille blank and lone surrogates in the command line, the names and the package index as \u
escapes, after it shortens them. The review of a registry server configuration also escapes private
use and unassigned characters and the braille blank. The registry prompt says that Save and a
reinstall ask again. Adds tests of the registry prompt after a version change and of an install
whose approval cannot be recorded.
@laileni-aws
laileni-aws changed the base branch from feature/security-fixes-v2 to feature/laileni-fixes November 18, 2026 20:38
@laileni-aws
laileni-aws force-pushed the fix/mcp-registry-consent branch from 72c6cb9 to aafe980 Compare November 18, 2026 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants