Repository navigation
fix(amazonq): check and pin the OAuth endpoints of remote MCP servers - #3071
Draft
laileni-aws wants to merge 2 commits into
Draft
laileni-aws wants to merge 2 commits into
laileni-aws wants to merge 2 commits into
Conversation
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
laileni-aws
force-pushed
the
fix/mcp-oauth-endpoints
branch
2 times, most recently
from
November 17, 2026 18:43
93bc4da to
4254b77
Compare
The OAuth client for remote MCP servers now checks each URL that it sends a request to during discovery, registration and sign-in, and each discovery redirect: https, or http on a loopback address, and an address in the scope of the MCP server. The authorization endpoint that the browser opens must be https, or http on a loopback address. A sign-in pins its token endpoint. A refresh uses only the pinned token endpoint, with the client registration and the token that it issued, and keeps the current refresh token when the response has none. A token saved before this change has no pinned endpoint, so the user signs in once in the browser. A client registration is saved only after a sign-in with it succeeds. Adds tests.
…h client Adds back the test that a loopback http authorization endpoint opens in the external browser. Adds a command URI and text that is not a URL to the authorization endpoints that must be refused, uses a public host name in the http resource_metadata test, and checks the authorization code and the sign-in error of two tests.
laileni-aws
changed the base branch from
feature/security-fixes-v2
to
feature/laileni-fixes
November 18, 2026 20:38
laileni-aws
force-pushed
the
fix/mcp-oauth-endpoints
branch
from
November 18, 2026 20:38
f8b1ea0 to
d1d5acc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.