Repository navigation
fix(rpc): bump practice writer protocol to runtime-rpc v2 (#328 P2) - #350
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After #348 replaced the runtime RPC
checkpointmethod withpracticeCheckpoint, both peers still advertisedarchcontext.runtime-rpc/v1. A new client could therefore treat an old daemon as compatible and miss the upgrade diagnosis. This independent follow-up closes the post-#348 RPC P2; refs #328.The active protocol is now
archcontext.runtime-rpc/v2, aligned across the current product manifest, schema, valid fixture, and fast hook. Header and body mismatches return HTTP 426 with the existing exact error string, expected/received versions, andarchctx daemon upgrade. The hook keeps its existing fail-open contract and reports the version mismatch in its message. Connection formatversion: 1and package/product release versions remain unchanged.Regression coverage:
rpc-version-mismatchandreceived=v1.prepareandpracticeCheckpointcalls leave the real practice baseline, every SQLite table, database/WAL bytes, and session rows unchanged;openSessionand baseline/session writes remain at zero.checkpointremains rejected without dispatch.Validation: focused pre-change tests fail on the v1 constant/400 response; final related suites pass with 515 pass, 1 existing platform-conditional skip, 0 fail across 12 files.
bun run typecheck,node scripts/package-boundary-audit.mjs,git diff --check, andnode scripts/packaged-cli-smoke.mjspass. File-backed plan received Claude read-only approval before implementation.Scope: RPC P2 only; no U4/#349
main.tsor scanner changes, D5–D7, release, aliases, historical evidence, or prior PR/comment rewrites. Keep Draft; no merge/deploy.