Repository navigation
ci: split slow Verify jobs with exact file coverage and strict summaries - #355
Merged
Merged
Conversation
Ancienttwo
marked this pull request as ready for review
October 14, 2026 23:11
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This was referenced Oct 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Verify can exhaust the existing 20-minute macOS / 60-minute Windows caps while tests keep passing. Split only the four measured timeout targets—macOS15/Node24, macOS15/Node25, Windows/Node22.22 and Windows/Node25—into three isolated whole-file test jobs. The other five targets retain complete verifiers.
This CI delivery is independent of #351 / #354. #354 remains frozen at
468df532; no product commits are included. Base:d6788c4b565aa043530b2f6407234b3ed108fa00. Review HEAD:d0fcb921b5fe088cf4406ad7280d5bf441170236. Keep Draft; no merge or serial integration yet.a10fafde, ended with 27 successful jobs, macOS25 and Windows22 execution timeouts/cancellations, and two correctly failed summaries. Neither cancelled execution log contained a(fail)marker. Windows22 finished main tests (3104 pass / 5 skip / 0 fail, 3352.16s), explorer and native smoke; the full packaged CLI smoke and later gates were unfinished. macOS25's main suite did not finish. This was not all-green.bun run verifyremains byte-for-byte unchanged. Post reinstalls dependencies and rebuilds its native bundle/Git/daemon fixtures. Only run-bound discovery/inventory/JUnit metadata crosses machines; tests keep real isolated processes, protocols and every product assertion.always()with current-attempt paginated job evidence; every expected worker must uniquely be completed/success with matching subject. Missing, skipped, cancelled, failed, duplicate or stale jobs fail. All nine FG6 summary names, IPC artifact semantics, permissions and caps remain unchanged.Second-round delta is limited to
.github/verify-sharding.json,scripts/verify-sharding-workflow.test.tsand the active runbook. The approved policy expectation expands from two to four targets. A real topology CLI regression checks four pre/post targets, twelve shards, five unsplit workers and 25 execution jobs; strict rejection cases cover each expected worker.Validation: 27 focused tests pass, 0 fail, 344 assertions; typecheck, package-boundary audit and diff checks pass. Workflow/controller/package bytes match the first candidate; actionlint1.7.12 passed on that unchanged workflow. The original native discovery census was 260 files, including 3 absent from old weights and excluding 1 deleted weighted path. No product/protocol assertions or historical verification artifacts changed.
Second-round CI: Verify 38647011093, queued when created; budget and results are pending. Detailed state/dependency audit, first-round failures, measured cost and next-run assumptions: verify sharding runbook.
Coordinator acceptance (2026-10-14 23:10 UTC): exact HEAD d0fcb92, Verify 38647011093 attempt 1 completed successfully; all 39 jobs and all nine named summaries passed. Independent static and incremental reviews found no blocking findings. Observed total: 273.23 raw runner minutes, 298 summed per-job-rounded minutes (model, not invoice), 27 installs / 12.28 minutes; sixteen extra shard/post installs / 7.22 minutes. First-to-last job wall clock 48m45s. One successful run supports acceptance, not a stable cost-saving claim. Prior pending language above describes the state when the candidate was first published.