Repository navigation
fix: preserve scoped public failure contracts (C1) - #359
Merged
Merged
Conversation
The Explorer failure-contract migration removed reasonCode interpolation, but its declaration-scoped audit still required that stale source string. Require the fixed observed-absence throw and all three safe facts, with independent removal and out-of-declaration negative tests. Preserve bounded reads, explicit graph authority and no-empty-observed refusal. Retain the non-green full-root evidence and approved targeted execution contrast without changing package product or test code.
Preserve reviewed A/B/C1 failure semantics, both scoped adapters and both test additions. Resolve only the shared stage whitelist by retaining both reviewed stage sets. All 502 tests across 18 complete affected files, types/boundaries, production audit and packaged native/CLI smoke pass with unchanged verification inputs. Keep the integration local until the current hosted run is terminal.
Ancienttwo
marked this pull request as ready for review
October 15, 2026 09:26
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Selected runtime, CLI, MCP and native failure boundaries now preserve registered classifications and safe actionable facts in strict bounded envelopes. Unknown escaping failures use fixed stages and do not infer provider causes from message text. Successful result shapes, side effects, and the explicitly held C2 recovery/lifecycle paths are preserved.
The existing production reachability and DE1/DE3 source-wiring audits now follow that contract. DE3 requires the current fixed observed-absence throw and all three facts (observed, unavailable, unclassified) inside the producing declaration. Independent removal negatives and an out-of-declaration fact test prevent accepting missing witnesses. Bounded reads, no-empty-observed fallback rejection and explicit graph authority checks remain intact. The final audit correction changes no package product/test or CI file and includes no unmerged B change.
Validation on b824f40:
Refs #328. This PR is the approved C1 slice and does not close the remaining D6 work.
Accepted-main integration
Head
1fd88cf61e2f5ba49914680fd43ba479266720b2merges accepted main670b7474d76d3cadfecc1b138513b6ed9546e7fcinto the reviewed C1 candidate. The only source conflict is the shared failure stage list, resolved as the union. B-only and C1-only code blobs are unchanged; both shared test additions remain intact.Affected verification passes: 502 tests / 6941 assertions across 18 complete files, plus typecheck, five-workspace boundary audit, production reachability audit and packaged native/CLI smoke. Source/test/check hashes are unchanged from the recorded verification. The historical default-execution full-root attempt remains non-green and is not claimed as a passing suite.
Old b824 Verify 38694500518 completed successfully before this ordinary push. Current exact-head Verify: 38701008450, completed successfully at attempt 2: all 43 jobs and all nine OS/Node summaries are green. Attempt 1's Windows25 ACL-fixture PowerShell subprocess timeout is retained as historical evidence. The fixture and test were byte-identical to the prior passing candidate; the single bounded retry reran topology and its dependency chain because attempt-bound artifacts prohibit a shard-only retry, retaining successful independent Governance/arm64 checks. No product code, assertions, permissions, or timeout budgets changed for the retry. Independent final integration review found no blockers, and no unresolved review threads remain. D6/C2 and D7 work is isolated and absent from this PR.