Repository navigation
Keep the kernel alive when a SystemExit escapes an asyncio task - #12
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
asyncio re-raises a
SystemExitfrom a task out of the event loop instead of storing it on the task, so a library call that raised one underasyncio.gatherended the kernel process.kernmini._bridge.run_loopnow drives the main loop and every child loop, re-entering after such an exit, and the cell that gathered the task completes with the exception in its results. The IPython story in the tests covers the main shell and a subshell, and the test kernel now launches through the publickernmini.run_kernel. See DEV.md, Python adapter.