Skip to content

SPEC mode: fix TIPTOP psf ingest - #1065

Open
janusbrink wants to merge 1 commit into
mainfrom
jb-fix-spec-tiptop-psf
Open

janusbrink wants to merge 1 commit into
mainfrom
jb-fix-spec-tiptop-psf

Conversation

@janusbrink

Copy link
Copy Markdown
Contributor

Squeeze 3D TIPTOP psf extensions down to 2D, both the data… and the WCS from the header. This was already done for imaging, but not for fov_cubes in SPEC mode.

@codecov

codecov Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.86%. Comparing base (2d24516) to head (1bdb682).
⚠️ Report is 28 commits behind head on main.

Files with missing lines Patch % Lines
scopesim/effects/psfs/discrete.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1065      +/-   ##
==========================================
- Coverage   74.87%   74.86%   -0.01%     
==========================================
  Files          70       70              
  Lines        9003     9004       +1     
==========================================
  Hits         6741     6741              
- Misses       2262     2263       +1     
Flag Coverage Δ
offline 72.55% <0.00%> (-0.01%) ⬇️
webtests 29.89% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@teutoburg teutoburg moved this to 👀 Awaiting Review in ScopeSim-development Nov 17, 2026
@teutoburg teutoburg added bugfix PR resolving one or more bugs (use "Bug" type for issues, not this label) effects Related to a ScopeSim effect spectroscopy Related to spectroscopic modes labels Nov 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix PR resolving one or more bugs (use "Bug" type for issues, not this label) effects Related to a ScopeSim effect spectroscopy Related to spectroscopic modes

Projects

Status: 👀 Awaiting Review

Development

Successfully merging this pull request may close these issues.

2 participants