Repository navigation
typescript: cross-process remote_edge for HTTP routes; context lists remote hops - #1710
Merged
Merged
Conversation
swapnilpaliwal-sd
requested review from
JaredHLZhang,
Whua689 and
suyashpaliwal26
as code owners
September 28, 2026 20:36
swapnilpaliwal-sd
force-pushed
the
loop/ty-is1293
branch
from
September 28, 2026 20:48
405e09a to
30f491e
Compare
…sts remote hops TypeScript had no framework-behavior phase, so no TS bundle held an ext_remote_edge row and impact/path stopped at the send. destinations.dl joins an HTTP client (fetch, an axios-style client or its create()d instance) to the route that serves it (router calls, @Controller/@get), reading the path from a literal, a template, a constant (local or imported) or a const config object. Verb must agree; the route with the fewest differing segments wins. Unjoined halves are reported as remote_unserved / remote_unsent / remote_undetermined. Framework names live in config-resolution/knobs.dl. context now prints ext_remote_edge rows as their own tier (transport, destination, confidence), never merged into call hops. impact's test closure walks a remote hop from sender to handler on its own `remote` rung, so test-impact selects the test that drives the client. Part of #1293 Co-authored-by: axiomcode-bot[bot] <334110751+axiomcode-bot[bot]@users.noreply.github.com> Co-Authored-By: Claude <noreply@anthropic.com>
swapnilpaliwal-sd
force-pushed
the
loop/ty-is1293
branch
from
September 28, 2026 21:55
30f491e to
bf4019e
Compare
swapnilpaliwal-sd
added a commit
that referenced
this pull request
Sep 28, 2026
…goldens tests: TS cases 68 and 69 expect #1710's remote_unsent section
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TypeScript now emits
remote_edgefor HTTP, andcontextlists remote hops as their own tier (transport, destination, confidence), never merged into call hops.graph/typescript/engine/framework-behavior/destinations.dl: joinsfetch/ an axios-style client (or itscreate()d instance) to router routes and@Controller/@Getroutes. It reads the path from a literal, a template, a local or imported constant, or a const config object. The verbs must match. Unjoined halves are reported as unserved, unsent or undetermined. Framework names are inconfig-resolution/knobs.dl.remoterung, so test-impact selects the test that drives the client.78-cross-process-destinations(literal, constant and configured shapes; a POST that must not match the GET handler).tests/cases/{typescript,java}/cross-process-routechecks impact, path, changed --impact, test-impact and context; the Java case is a regression guard.tests/casessuite shows 3 failures that also fail on the base engine. The full TS golden suite was still running when this was opened.Part of #1293