Repository navigation
impact: label each link of a chained route registration with its own verb and path - #1722
Merged
swapnilpaliwal-sd merged 2 commits intoSep 29, 2026
Merged
Conversation
…verb and path `router.get(p1, a).get(p2, b).post(p3, c)` is three call sites that all start where `router` starts, so each link was read over its receiver's span: every handler was reported as the first link's GET route on the chain's first line. The chain is now walked innermost first; each link takes the first path in its own part, a link with none (router.route(p).get(h)) keeps its receiver's, and an edge at a chained route link sits on the link's own line in both the `calls` fact and the SQL rows. IMPACT_VERSION 39 drops cached facts. Co-authored-by: axiomcode-bot[bot] <334110751+axiomcode-bot[bot]@users.noreply.github.com>
swapnilpaliwal-sd
requested review from
JaredHLZhang,
Whua689 and
suyashpaliwal26
as code owners
September 28, 2026 23:42
… calls it The nearest-callers row read the call site's start line, which for a chained registration is the chain's first line. It now takes the link's own line from route_site_lines, as impact does. Co-authored-by: axiomcode-bot[bot] <334110751+axiomcode-bot[bot]@users.noreply.github.com>
swapnilpaliwal-sd
deleted the
loop/ja-chained-route-verbs-mislabelled
branch
September 29, 2026 00:06
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Each link of a chained registration
router.get(p1, a).get(p2, b).post(p3, c)was labelled with the first link's verb and path on the chain's first line, because every link's call site spans its receiver.impactnow labels each link with its own verb, path and line, andpathnames that line as where the direct caller calls it. A link with no path of its own (router.route(p).get(h).put(h2)) keeps route()'s path as before.javascript/chained-route-verbs(9 checks, including controls: the first link,route(p)over several lines and on one line, a plain registration)GET "/" :24toGET "/post/new" :25,GET "/post/:id" :26,POST "/post" :27. Edges unchanged (798 = 798, fixture 78 = 78), index time unchanged (~5.9s)IMPACT_VERSION39 drops cached facts