Repository navigation
javascript: this.x() with no declared x answers unknown in path - #1724
Merged
Merged
Conversation
…swers unknown A method calling this.hook() where neither the class, an ancestor nor any write the graph follows gives the instance a hook runs a function stored from outside (e.hook = fn, Object.assign(this, opts)). It is now an unresolved value callee (instance_member), so path says unknown and names the site instead of independent. Classes with an unresolved or dynamic base are left out, as are ambient members (hasOwnProperty). Closes #1709 Co-authored-by: axiomcode-bot[bot] <334110751+axiomcode-bot[bot]@users.noreply.github.com>
swapnilpaliwal-sd
requested review from
JaredHLZhang,
Whua689 and
suyashpaliwal26
as code owners
September 28, 2026 23:58
This was referenced Sep 29, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
path A Banswered "independent" when A callsthis.x()andxis only put on the instance from outside the class (e.hook = fn,Object.assign(this, opts)).instance_member);pathanswers UNKNOWN and names the site.hasOwnProperty);this.x = xkeeps itsfieldreading.68-instance-member-calleeand CLI caseinstance-member-callee-is-unknownwith those controls.Checked: JS golden suite 76/76; new CLI case 6/6 (2 fail on 0.1.7); call edges and value-callee counts identical before/after on 6 real JS apps + 4 synthetic corpora. 3 JS CLI cases fail on 0.1.7 with or without this change.
Closes #1709