Repository navigation
impact, test-impact: a script-style test counts as a test and runs by its own command - #1729
Merged
Merged
Conversation
swapnilpaliwal-sd
requested review from
JaredHLZhang,
Whua689 and
suyashpaliwal26
as code owners
September 29, 2026 00:50
… its own command A test-tree file run as a program with no framework (a runner calling runCase at top level, a tests/check.py with a main guard) was walked to and labelled [test], then counted "0 of 0", and test-impact said no test reaches the change. Its module is now in test_method, from one rule (graph_sql.script_tests) that the exporter and the hooks' fast path both read, so impact counts it and test-impact selects it. The command is the one the project runs it by: its package script, its usage line, else the interpreter; never a guessed framework. Helpers that export, setup and config files, and test data (cases/, fixture projects under src/, tools/) are not scripts. The impact facts version moves to 40 so a cached export is rebuilt. Also: axiomcode-path declared G.enclosing twice, the second shadowing the first, so `changed <file>` without git crashed on a top-level lambda. The file:line form is now G.enclosing_at. Co-authored-by: axiomcode-bot[bot] <334110751+axiomcode-bot[bot]@users.noreply.github.com>
…ds its own entry An unguarded script test that no package script or usage line names was handed to node or npx tsx, which undid #1570 (a file nothing runs is said so). It still counts and is selected; only a file with require.main === module, import.meta.main or a __main__ guard gets its interpreter as the command. Co-authored-by: axiomcode-bot[bot] <334110751+axiomcode-bot[bot]@users.noreply.github.com>
swapnilpaliwal-sd
force-pushed
the
loop/to-t2-1
branch
from
September 29, 2026 01:17
cf266b4 to
04efea7
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A test-tree file that runs as a plain program with no test framework (a runner calling
runCaseat top level, atests/check.pywith a main guard) was reached and labelled[test], but still countedtests: 0 of N, and test-impact said no test reaches the change.graph_sql.script_tests), so both count these scripts and test-impact selects them.G.enclosingthat crashedchanged <file>on a top-level lambda.npm run test. This repo'sgraph_sql.pyedit now selectstests/fastpath.py. Control is unchanged on two real Express apps (88/113, 2/113, 0/9, 0/9). Golden suite: 753/761; all 7 failures also fail on 0.1.7, which fails 6 more lambda checks.script_tests,fastpath,test_commandandfreshnesspass.changed_rangehas the same 4 failures as on 0.1.7.