Repository navigation
impact / path: --in chooses among the files a partial file:line path matches - #1735
Merged
Merged
Conversation
swapnilpaliwal-sd
requested review from
JaredHLZhang,
Whua689 and
suyashpaliwal26
as code owners
September 29, 2026 01:12
…matches A file:line whose partial path (a basename, or dir/file) matches several indexed files was refused before --in was applied, so the scope could not pick among them. G.line_files now narrows the matches by --in: one file under the scope is the answer, labelled with its full path; two or more are the refusal's list; none keeps the whole list and says so. impact's field lookup for file:line matched the line in every file the path ends, so test.js:6 among 17 test.js answered for one file's const; it now resolves the file the same way and refuses when the path is ambiguous. Closes #1666 Co-authored-by: axiomcode-bot[bot] <334110751+axiomcode-bot[bot]@users.noreply.github.com>
swapnilpaliwal-sd
force-pushed
the
loop/ja-is1666
branch
from
September 29, 2026 01:22
44e5020 to
19bd139
Compare
This was referenced Sep 29, 2026
Merged
Contributor
Author
|
Rebased onto 0.1.7 (after #1734; kept both the line-outside-file check and the scope choice). file:line cases 45/45 incl. fileline-line-outside-file; script_tests ok. Full local case suite before the rebase: 749/761, and the 11 failing checks fail identically with the 0.1.7 scripts. |
Contributor
Author
|
Correction: the merged commit already carried the same rebase onto #1734; my later push was rejected and nothing further went in. The check results above hold for that same resolution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--innow chooses among the files a partialfile:linepath matches, forimpactandpath.G.line_filesnarrows the matches by the scope: one file under it is the answer, labelled with its full path (runA (at packages/a/src/index.js:2)); two or more are refused, listing only those; none keeps the full list and says so.test.js:6among 17test.jsanswered for one file's const without refusing. It now uses the same file resolution.javascript/fileline-partial-path-in-scope(5index.js, 2config.js) with controls: no--in, full path, a single-match partial path, a scope holding two files, a scope holding none.Checked: fixture 20/20 checks (both file:line cases); a real Express app (17
test.js, 798 call edges, graph unchanged):impact test.js:6 --in blognow answersblog/test.js:6(0.28s, was 0.25s); thecsrf/test.js:6control is unchanged. The full case suite was still running locally when this PR opened.Closes #1666