Repository navigation
javascript: a function passed as a JSX attribute is a registered hand-off - #1741
Merged
swapnilpaliwal-sd merged 2 commits intoSep 29, 2026
Merged
Conversation
… hand-off
onSubmit={submit}, onClick={h}, <UserForm action={create}/> had no incoming
edge, so impact called the handler unused. Each attribute whose value is a
function now emits a callback_registered edge (kind JSX_ATTRIBUTE) from the
callable holding the markup, on any tag, as a call argument does.
Co-authored-by: axiomcode-bot[bot] <334110751+axiomcode-bot[bot]@users.noreply.github.com>
swapnilpaliwal-sd
requested review from
JaredHLZhang,
Whua689 and
suyashpaliwal26
as code owners
September 29, 2026 02:06
Co-authored-by: axiomcode-bot[bot] <334110751+axiomcode-bot[bot]@users.noreply.github.com>
swapnilpaliwal-sd
deleted the
loop/ja-js-jsx-attribute-handler-unused
branch
September 29, 2026 03:49
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A function passed as a JSX attribute (
<form onSubmit={submit}>,onClick={h},<UserForm action={createUser}/>) had no incoming edge, soimpactcalled it unused and a delete looked safe. A call argument is already treated as a hand-off.jsx.dl: an attribute whose value is a function emits acallback_registerededge (new kindJSX_ATTRIBUTE) from the callable that holds the markup. This works on any tag, the same way a call argument does.70-jsx-attribute-handlercovers handlers on intrinsic tags, an inline arrow and a server action passed to a component. Its control attributes (value={count},className,title={label()}, an object) produce no edge. Case 62 gains 3 edges of the same kind.--oracle(2 re-blessed), bundle-test ok (SCHEMA.md regenerated).