Repository navigation
typescript: --closed-world on narrows the dispatch fan to constructible types, and records it - #1788
Merged
Merged
Conversation
…le types, and records it type_instantiated was computed and never read, so a TypeScript multi_inferred fan was every override the hierarchy admits (CHA), while Python's is narrowed to what the program builds. Narrowing is only sound when every construction is visible, so it is opt-in: - --closed-world on (env AXIOM_DISPATCH_CLOSED_WORLD) admits an implementor only if a constructible type conforms to it: a typed `new`, or the class used as a value anywhere, in its own module (TYPE) or imported into another (IMPORT_BINDING, the container `useClass: X` shape); - each edge the premise removes is a dispatch_assumes_closed_world row (assumption-dispatch-closed-world.csv), and run.dispatch_closed_world says which mode ran; - the default fan and every golden are unchanged. Case 83 pins the default fan; closed-world-dispatch-test.sh solves it with the flag on: Unused, Orphan and TypeOnly drop (3 assumption rows), Built, Registered, Base (inherited by a constructed Leaf) and Provided (imported, handed over as useClass) stay. Co-authored-by: axiomcode-bot[bot] <334110751+axiomcode-bot[bot]@users.noreply.github.com> Co-Authored-By: Claude <noreply@anthropic.com>
swapnilpaliwal-sd
requested review from
JaredHLZhang,
Whua689 and
suyashpaliwal26
as code owners
September 29, 2026 07:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TypeScript multi_inferred dispatch was class-hierarchy wide because type_instantiated was never read. New opt-in
--closed-world on(env AXIOM_DISPATCH_CLOSED_WORLD): an implementor stays in the set only if the program can construct a type that conforms to it (a typednew, or the class used as a value, locally or imported). Each edge removed is exported as adispatch_assumes_closed_worldassumption row;run.dispatch_closed_worldrecords the mode. Default behaviour unchanged.Closes #473