Repository navigation
javascript: handlers reached through React context or redux connect props are registered - #1789
Merged
Merged
Conversation
…edux connect props are registered useContext(Ctx) / use(Ctx) / <Ctx.Consumer> now evaluate to the value of every <Ctx.Provider value> of the same createContext call (followed through consts and imports, never by name), plus its default. connect(mapState, mapDispatch)(C) is a component wrapper and hands C (props param or this.props) what the map functions return, or the object form of mapDispatch. useMemo/useCallback pass their value on. Controls: another context's same-named key, an unconnected component, a plain non-curried connect(), and a separately connected subclass stay unchanged. Closes #1751 Co-authored-by: axiomcode-bot[bot] <334110751+axiomcode-bot[bot]@users.noreply.github.com> Co-Authored-By: Claude <noreply@anthropic.com>
swapnilpaliwal-sd
requested review from
JaredHLZhang,
Whua689 and
suyashpaliwal26
as code owners
September 29, 2026 07:16
swapnilpaliwal-sd
added a commit
that referenced
this pull request
Sep 29, 2026
Conflict in decls_all.dl with #1789: keep both sets of jsx declarations. Co-authored-by: axiomcode-bot[bot] <334110751+axiomcode-bot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
useContext(Ctx)/use(Ctx)/<Ctx.Consumer>evaluate to thevalueof every<Ctx.Provider>of the samecreateContextcall (plus its default); matched by the call, not the name.connect(mapState, mapDispatch)(C)is a component wrapper and hands C's props (function param orthis.props) what the map functions return, or the object form.useMemo/useCallbackpass their value on.72-jsx-context-connect-propswith controls: another context's same-named key, an unconnected component, a non-curriedconnect(), a separately connected subclass.Checked: JS suite 87/87 with
--oracle; fixture 36→45 edges; a real redux app 462→476 edges (known 96→143, ambiguous 224→176), no resolved edge lost, index time 4.49s→4.61s.Closes #1751