Repository navigation
path, impact: a file:line in a class body but in no member is refused, naming the members either side - #1798
Merged
swapnilpaliwal-sd merged 1 commit intoSep 30, 2026
Conversation
…bers is refused, naming the members either side A line number copied before an edit often lands on a blank or doc-comment line between two methods. Where a class body has no module node of its own (TypeScript, JavaScript, Java, C#), that line fell through to the file's module and was answered as its top-level code, with nothing saying the line held no declaration; Java said only "no callable spans". It is now refused with the enclosing type and the nearest declaration above and below it. A Python class body is a module node inside the type and answers as before. Checked: new checks in fileline-line-outside-file (JS) and fileline-dotted-basename (TS) fail before (3 of 32) and pass after (32 of 32); graph unchanged (9988 call edges on a real NestJS repo either way).
swapnilpaliwal-sd
requested review from
JaredHLZhang,
Whua689 and
suyashpaliwal26
as code owners
September 30, 2026 00:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
file:lineon a blank or doc-comment line between two members of a class was answered as the whole file's top-level code (TypeScript, JavaScript), or as a bare "no callable spans" (Java), with nothing saying the line holds no declaration. This is what a line number copied before an edit looks like.impactandpathshare the resolver.fileline-line-outside-file(JS) andfileline-dotted-basename(TS) cases, no new directory.<module>answer hid that.Checked: new checks 3 of 32 fail before, 32 of 32 pass after; TS suite 97/0; cases JS 239/239, Java 298/298, TS/Python/C# failures identical to base; a real NestJS repo has 9988 call edges before and after, probes 29/73 before and after.