Repository navigation
engine: a library-wrapped function kept in a const is registered where the const is handed over - #1799
Merged
swapnilpaliwal-sd merged 1 commit intoSep 30, 2026
Conversation
…egistered where the const is handed over TypeScript: a const whose initializer is a boundary call handed a function (fp(async (app) => ...), defineExtension(fn)) hands that function on to a library registration it is passed to, by name or through an import. Not a reassignment, not a call through a project value, not a call whose typed result has no call signature. JavaScript: the same, for a call rooted at a package import, carried as its own value kind that is never a callee. path answered 'independent' for a plugin registered this way although the bare form was reached. Co-authored-by: axiomcode-bot[bot] <334110751+axiomcode-bot[bot]@users.noreply.github.com>
swapnilpaliwal-sd
requested review from
JaredHLZhang,
Whua689 and
suyashpaliwal26
as code owners
September 30, 2026 01:04
swapnilpaliwal-sd
deleted the
apps/typescript/value-wrapped-callback-registration
branch
September 30, 2026 02:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
export const plugin = wrap(async (app) => …)thenhost.register(plugin): the registration did not reach the literal, andpathsaid the two were independent, although the literal handed over bare was reached.value-flow.dl): a const whose initializer is a boundary call handed a function passes that function on to a boundary call the const is handed to, by name or through an import. Excluded: a reassignment, a call through a project value, and a call whose typed result has no call signature.callbacks.dl): the same for a call rooted at a package import, carried as alibwrapvalue that is never a callee, so call classification is unchanged.hof-callback-at-library-boundaryand JS case 34, each with a control (a const built from a plain value registers nothing). The TS case said "independent" before the fix.