Repository navigation
impact, hooks: a caller is its declaration, not its display name - #1807
Merged
swapnilpaliwal-sd merged 1 commit intoSep 30, 2026
Conversation
Every unnamed function carries one display (<arrow>, <function-expression>, <lambda>, <anonymous-method>) and every module body of a basename another. Keyed by that name, file:line on an arrow answered for every arrow, an edit inside an arrow came back as a removed <arrow>, and the hook's fast path merged all same-named callers into one row located at whichever came first. - the unnamed-function names of every front end are never a target on their own - the fast path keys callers by id and locates each at its lowest call site, as the rules do - the parity check compares direct rows with their locations - a JavaScript case for arrows and function expressions, with a named-function control Co-authored-by: axiomcode-bot[bot] <334110751+axiomcode-bot[bot]@users.noreply.github.com>
swapnilpaliwal-sd
requested review from
JaredHLZhang,
Whua689 and
suyashpaliwal26
as code owners
September 30, 2026 03:51
swapnilpaliwal-sd
deleted the
apps/javascript/anonymous-and-module-declarations-merged
branch
September 30, 2026 06:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every unnamed function shares one display name (
<arrow>,<function-expression>,<lambda>,<anonymous-method>), and so do module bodies that share a basename. Keying declarations by that name merged unrelated ones.<arrow>,<function-expression>and<anonymous-method>join<lambda>as names that are never a target on their own. file:line on an arrow now answers for that one arrow, and an edit inside an arrow is a body change of the function that encloses it, not "removed ".Checked: JS engine suite 89/89. The case suites have no new failures; the ones that remain also fail without this change. Product probes are 47/70 before and after, with 0 regressions. Call edges stay at 8960.